[TIMOB-2336] iOS: Filesystem.isExteralStoragePresent mispelled and always returns false

GitHub Issue	n/a
Type	Bug
Priority	Medium
Status	Closed
Resolution	Fixed
Resolution Date	2011-04-17T01:58:48.000+0000
Affected Version/s	n/a
Fix Version/s	Backlog
Components	iOS
Labels	defect, filesystem.isexteralstoragepresent, ios
Reporter	jtobias
Assignee	jtobias
Created	2011-04-15T03:17:02.000+0000
Updated	2011-04-17T01:58:48.000+0000

Description

ENVIRONMENT:
version=1.5.0
timestamp=11/12/10 10:37
githash=937631f

STEPS TO REPRODUCE:
1) Note that code in titanium_mobile/iphone/Classes/FilesystemModule.m, method isExteralSpaceAvailable
always returns "false" (despite existing external storage options) - "as designed" in Titanium API?
2) Note also "exteral" is misspelled, should be "external" with an 'n'
3) Both 1) and 2) are reflected in the tdoc file Filesystem.tdoc

SUGGESTED FIX:
Use a macro or method to direct both the misspelled and correctly spelled method both work, or add the correct spelling and depcreate the incorrect? It's also misspelled in the tdoc file

Comments

Dawson Toth 2011-04-15

The following Helpdesk ticket concerns this misspelling as well. It's showing up in the mobile docs on the website.

http://developer.appcelerator.com/helpdesk/view/62161">http://developer.appcelerator.com/helpdesk/view/62161
Don Thorp 2011-04-15

Created #2709 to track the documentation issue.
Jeff Haynie 2011-04-15

(from [14e0c14ebfa398900ea266347daeb11fe255e236]) [#2336 state:fixed-in-qa] Typo fixed, property changed into a method, docs updated. External storage is an android-only concept, so returning false is expected behavior. https://github.com/appcelerator/titanium_mobile/commit/14e0c14ebfa398900ea266347daeb11fe255e236"> https://github.com/appcelerator/titanium_mobile/commit/14e0c14ebfa3...
Jeff Haynie 2011-04-15

(from [11dd2b64ad09ae71a0bdef8279f569a69c58b681]) [#2336] Whoops. Now it's fixed-in-qa! https://github.com/appcelerator/titanium_mobile/commit/11dd2b64ad09ae71a0bdef8279f569a69c58b681"> https://github.com/appcelerator/titanium_mobile/commit/11dd2b64ad09...
Andre Carregal 2011-04-15

Please consider adding an API spell check step for your product release workflow, or at least let the documentation team know that mixed case words should also be check spelled and eventual idiosyncrasies should be discussed with the dev team.

While I agree that such errors can be reverted after a release, the impact in client code should not be considered lightly and, for many developers, this could reflect badly on the framework reputation.
Thomas Huelbert 2011-04-15

confirmed typo fix in noted .m file [INFO] Titanium SDK version: 1.6.0 (01/12/11 09:38 db09d1e)

JSON Source