{ "id": "167464", "key": "TIMOB-24659", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "18414", "description": "", "name": "Release 6.2.0", "archived": false, "released": true, "releaseDate": "2017-09-13" }, { "id": "19882", "name": "Release 8.0.0", "archived": false, "released": true, "releaseDate": "2019-03-14" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2019-01-09T23:17:20.000+0000", "created": "2017-05-05T00:40:23.000+0000", "priority": { "name": "Critical", "id": "1" }, "labels": [], "versions": [], "issuelinks": [], "assignee": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "updated": "2019-01-09T23:17:51.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" }, { "id": "10207", "name": "Tooling" } ], "description": "Android 7.1 allow applications to show a circular icon in the launcher, for devices that supports them (ex. Pixel & Pixel XL). \r\n\r\nTitanium should support the android:roundIcon attribute in AndroidManifest.xml.\r\n\r\n{code:lang=xml}\r\n \r\n{code}\r\n\r\n", "attachment": [], "flagged": false, "summary": "Android: Add support for the roundIcon attribute", "creator": { "name": "gaspard.le", "key": "gaspard.le", "displayName": "Luc-Edmond Gaspard ", "active": true, "timeZone": "America/Montreal" }, "subtasks": [], "reporter": { "name": "gaspard.le", "key": "gaspard.le", "displayName": "Luc-Edmond Gaspard ", "active": true, "timeZone": "America/Montreal" }, "environment": null, "closedSprints": [ { "id": 883, "state": "closed", "name": "2017 Sprint 09 SDK", "startDate": "2017-04-23T21:46:54.309Z", "endDate": "2017-05-07T21:46:00.000Z", "completeDate": "2017-05-08T00:25:44.276Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "419149", "author": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "body": "https://github.com/appcelerator/titanium_mobile/pull/9019", "updateAuthor": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "created": "2017-05-05T04:24:00.000+0000", "updated": "2017-05-05T04:24:00.000+0000" }, { "id": "419169", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "Thank you [~gaspard.le]! Hey [~gmathews], can you check this? Looks like a simple addition to the manifest.", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2017-05-05T12:42:15.000+0000", "updated": "2017-05-05T12:42:15.000+0000" }, { "id": "422899", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Verified the fix.\r\n\r\nSpecifying {{android:roundIcon=\"@mipmap/ic_launcher_round\"}} in the {{tiapp.xml}} add it to the {{androidmanifest.xml}}. Build picks up the correct icons if round icons are included in the {{platform/android/res/}} folder if app is built for android 25 & above.\r\n\r\nClosing.\r\n\r\nStudio Ver: 4.9.0.201705302345\r\nSDK Ver: 6.2.0.v20170626084207\r\nOS Ver: 10.12.3\r\nXcode Ver: Xcode 8.3.3\r\nAppc NPM: 4.2.9\r\nAppc CLI: 6.2.2\r\nTi CLI Ver: 5.0.14\r\nAlloy Ver: 1.9.11\r\nNode Ver: 6.10.1\r\nJava Ver: 1.8.0_101\r\nDevices: ⇨ google Nexus 5 --- Android 6.0.1\r\n ⇨ google Pixel --- Android 7.1.1\r\nEmulator: Android 4.4.2", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-06-26T22:46:47.000+0000", "updated": "2017-06-26T22:46:47.000+0000" }, { "id": "440734", "author": { "name": "nipoul", "key": "nipoul", "displayName": "Nikos Poulios", "active": true, "timeZone": "Europe/Berlin" }, "body": "The fix is valid but it seems it never made it into a release and its mistakenly marked as closed in version 6.2.0\r\nCheck https://github.com/appcelerator/titanium_mobile/blob/master/android/cli/lib/AndroidManifest.js. It is not even included in 6.2.0 branch", "updateAuthor": { "name": "nipoul", "key": "nipoul", "displayName": "Nikos Poulios", "active": true, "timeZone": "Europe/Berlin" }, "created": "2018-08-14T08:50:56.000+0000", "updated": "2018-08-14T08:50:56.000+0000" }, { "id": "440737", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "This is interesting. I cannot find it on master and 6_2_X either. But in any case, I think using [adaptive icons|https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive] on Android is the way moving forward these days anyway. It adapts the icon (round, square, dynamic) based on the API-level and manufacturer. We use it for our [hyperloop-examples|https://github.com/appcelerator/hyperloop-examples] app and they can simply be created via a sample project in Android Studio and then be copied over to your app. Still, we should check what was going wrong here.", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2018-08-14T08:57:29.000+0000", "updated": "2018-08-14T08:57:29.000+0000" }, { "id": "445140", "author": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "body": "master: https://github.com/appcelerator/titanium_mobile/pull/10598", "updateAuthor": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-01-09T18:34:03.000+0000", "updated": "2019-01-09T18:34:03.000+0000" }, { "id": "445153", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Master PR Merged.", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-01-09T22:41:33.000+0000", "updated": "2019-01-09T22:41:33.000+0000" } ], "maxResults": 8, "total": 8, "startAt": 0 } } }