{ "id": "169812", "key": "TIMOB-25311", "fields": { "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [], "resolution": { "id": "11", "description": "Is not a bug in our product", "name": "Not Our Bug" }, "resolutiondate": "2017-11-29T07:50:11.000+0000", "created": "2017-09-16T23:02:17.000+0000", "epic": { "id": 169755, "key": "TIMOB-25267", "name": "iOS: Add support for iPhone X", "summary": "iOS: Add support for iPhone X", "color": { "key": "color_5" }, "done": false }, "priority": { "name": "Critical", "id": "1" }, "labels": [ "iphonex", "toolbar" ], "versions": [ { "id": "18414", "description": "", "name": "Release 6.2.0", "archived": false, "released": true, "releaseDate": "2017-09-13" } ], "issuelinks": [], "assignee": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "updated": "2018-08-06T17:52:04.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10206", "name": "iOS", "description": "iOS Platform" } ], "description": "This is in relation to the win.toolbar that shows at the bottom of the window. \r\n\r\nI \"think\" the issue is the height of the toolbar? Really not sure how else this issue would be resolved without some pretty ugly \"hacks\".\r\n\r\nPlease see the attached screenshot that highlights the issue. ", "attachment": [ { "id": "63301", "filename": "iPhone_X_-_iOS_11_0_and_Desktop_—_Local.png", "author": { "name": "mdelmarter", "key": "mdelmarter", "displayName": "Matthew Delmarter", "active": true, "timeZone": "Pacific/Auckland" }, "created": "2017-09-16T22:58:57.000+0000", "size": 23944, "mimeType": "image/png" }, { "id": "63308", "filename": "Simulator Screen Shot - iPhone X - 2017-09-18 at 15.02.32.png", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2017-09-18T13:03:04.000+0000", "size": 60930, "mimeType": "image/png" }, { "id": "63523", "filename": "TestToolbarInTab.zip", "author": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-11-02T08:31:39.000+0000", "size": 38979, "mimeType": "application/zip" } ], "flagged": false, "summary": "iPhone X: Height / Inset of Window Toolbar", "creator": { "name": "mdelmarter", "key": "mdelmarter", "displayName": "Matthew Delmarter", "active": true, "timeZone": "Pacific/Auckland" }, "subtasks": [], "reporter": { "name": "mdelmarter", "key": "mdelmarter", "displayName": "Matthew Delmarter", "active": true, "timeZone": "Pacific/Auckland" }, "environment": null, "closedSprints": [ { "id": 975, "state": "closed", "name": "2017 Sprint 24 SDK", "startDate": "2017-11-19T18:59:24.352Z", "endDate": "2017-12-03T18:59:00.000Z", "completeDate": "2017-12-04T23:20:14.151Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "427977", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "To be clear, the expected layout would be that it would fill the rounded bottom-part of the screen as well? Will check how it's looking natively.", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2017-09-17T12:52:57.000+0000", "updated": "2017-09-17T12:53:07.000+0000" }, { "id": "427980", "author": { "name": "mdelmarter", "key": "mdelmarter", "displayName": "Matthew Delmarter", "active": true, "timeZone": "Pacific/Auckland" }, "body": "It is a good question Hans. I have no idea how Apple solved this at a native level. From a logical perspective I would hope that it replicates the behaviour of the navigation bar extending to the top of the iPhone X screen. So yes, hopefully it will fill the rounded bottom part, that would be nice.", "updateAuthor": { "name": "mdelmarter", "key": "mdelmarter", "displayName": "Matthew Delmarter", "active": true, "timeZone": "Pacific/Auckland" }, "created": "2017-09-17T21:58:58.000+0000", "updated": "2017-09-17T21:58:58.000+0000" }, { "id": "428013", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "Tested it out, looks correct for me: \r\n\r\n !Simulator Screen Shot - iPhone X - 2017-09-18 at 15.02.32.png|thumbnail!\r\n\r\nTest-Case:\r\n{code:js}\r\n\r\nvar win = Ti.UI.createWindow({\r\n backgroundColor: '#fff',\r\n toolbarSettings: {\r\n translucent: false,\r\n animated: false,\r\n barColor: '#ccc'\r\n },\r\n toolbar: [Ti.UI.createButton({title: 'Whoop!'})]\r\n});\r\n\r\nvar nav = Ti.UI.iOS.createNavigationWindow({\r\n window: win\r\n})\r\n\r\nnav.open();\r\n{code}", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2017-09-18T13:03:10.000+0000", "updated": "2017-09-18T13:03:37.000+0000" }, { "id": "428231", "author": { "name": "mdelmarter", "key": "mdelmarter", "displayName": "Matthew Delmarter", "active": true, "timeZone": "Pacific/Auckland" }, "body": "I created a test case for you. The issue manifests itself when you use tabs:\r\n\r\n{code:javascript}\r\nvar tabGroup = Ti.UI.createTabGroup();\r\n\r\nvar win1 = Ti.UI.createWindow({\r\n title: 'Window 1',\r\n backgroundColor: 'blue',\r\n toolbarSettings: {\r\n translucent: false,\r\n animated: false,\r\n barColor: 'red'\r\n }\r\n});\r\n\r\nvar tab1 = Ti.UI.createTab({\r\n title: 'Tab 1',\r\n window: win1\r\n});\r\n\r\ntabGroup.addTab(tab1);\r\n\r\nwin1.setToolbar([Ti.UI.createButton({title: 'Whoop!'})]);\r\n\r\ntabGroup.open();\r\n{code}\r\n\r\nIn my first screenshot, I was hiding the tabGroup while entering a multi-select mode etc. Anyway the test case shows the following gap under the toolbar...\r\n\r\n!https://www.evernote.com/shard/s1/sh/7ca0f3ae-13b7-47a8-a72a-5327e5a231bd/0693a7170c5e3f0a/res/e3c281e6-53d6-4b9c-80b4-0fac8befad8c/skitch.png?resizeSmall&width=832!\r\n\r\n", "updateAuthor": { "name": "mdelmarter", "key": "mdelmarter", "displayName": "Matthew Delmarter", "active": true, "timeZone": "Pacific/Auckland" }, "created": "2017-09-21T09:24:24.000+0000", "updated": "2017-09-21T09:25:20.000+0000" }, { "id": "429994", "author": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "body": "This problem is happening in native iOS app as well . Attached is sample native iOS app as \" TestToolbarInTab.zip\". This is bug from apple side for iPhone X . People have discussed about it [https://forums.developer.apple.com/thread/86982|https://forums.developer.apple.com/thread/86982] and [https://stackoverflow.com/questions/46205703/ios-11-iphone-x-uinavigationbars-toolbar-spacing-incorrect-when-embedded-in|https://stackoverflow.com/questions/46205703/ios-11-iphone-x-uinavigationbars-toolbar-spacing-incorrect-when-embedded-in].\r\n\r\nIf we use custom toolbar, this problem will not happen -\r\n\r\n\r\n{code:java}\r\nvar tabGroup = Ti.UI.createTabGroup();\r\n var win1 = Ti.UI.createWindow({\r\n title: 'Window 1',\r\n backgroundColor: 'blue',\r\n});\r\n var tab1 = Ti.UI.createTab({\r\n title: 'Tab 1',\r\n window: win1\r\n});\r\n tabGroup.addTab(tab1); \r\nvar whoop = Ti.UI.createButton({\r\n title: 'Whoop!'\r\n});\r\nvar toolbar = Ti.UI.createToolbar({\r\n items: [whoop],\r\n bottom: 0\r\n});\r\nwin1.add(toolbar);\r\ntabGroup.open();\r\n{code}", "updateAuthor": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-11-02T08:40:39.000+0000", "updated": "2017-11-02T09:19:23.000+0000" }, { "id": "430139", "author": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Filed bug to apple -\r\nhttps://openradar.appspot.com/35358090.", "updateAuthor": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-11-06T04:14:53.000+0000", "updated": "2017-11-06T04:14:53.000+0000" }, { "id": "431276", "author": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "body": "This issue has been marked duplicate by Apple and marked closed. I have verified it in Xcode 9.2 beta with iPhone X (11.2 beta), problem is not happening. It looks it is fixed in iOS 11.2 . \r\n", "updateAuthor": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-11-27T04:14:44.000+0000", "updated": "2017-11-27T04:14:44.000+0000" }, { "id": "440263", "author": { "name": "emerriman", "key": "emerriman", "displayName": "Eric Merriman ", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Closing as \"not our bug\". If you disagree, please reopen.", "updateAuthor": { "name": "emerriman", "key": "emerriman", "displayName": "Eric Merriman ", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-08-06T17:52:04.000+0000", "updated": "2018-08-06T17:52:04.000+0000" } ], "maxResults": 9, "total": 9, "startAt": 0 } } }