{ "id": "170527", "key": "TIMOB-25582", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "19882", "name": "Release 8.0.0", "archived": false, "released": true, "releaseDate": "2019-03-14" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2018-11-20T01:52:41.000+0000", "created": "2017-12-04T04:38:47.000+0000", "priority": { "name": "High", "id": "2" }, "labels": [ "breaking-change" ], "versions": [ { "id": "17609", "description": "", "name": "Release 7.0.0", "archived": false, "released": true, "releaseDate": "2017-12-07" } ], "issuelinks": [ { "id": "56197", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "inwardIssue": { "id": "170523", "key": "TIMOB-25581", "fields": { "summary": "Windows: borderWidth should be changed 0 to 1 when borderColor is set", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "Medium", "id": "3" }, "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false } } } }, { "id": "56958", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "inwardIssue": { "id": "172523", "key": "TIMOB-26503", "fields": { "summary": "Windows: Touch event coordinate units do not match between platforms", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "High", "id": "2" }, "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false } } } } ], "assignee": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "updated": "2018-11-20T11:54:27.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "12642", "name": "Windows", "description": "Windows authoring support" } ], "description": "According to the document, \r\n\r\n{quote}\r\nYou can specify the default unit type to use with untyped values. To the tiapp.xml file, you would add\r\nvalue\r\n\r\nWhere value is one of px, mm, cm, in, dp, dip, or system. The \"system\" value corresponds to the platform-dependent system unit as described above. \r\n{quote}\r\n\r\nCurrent default units are hard-coded to {{\"px\"}}.\r\n\r\nSee also: [Setting default units in tiapp.xml|http://docs.appcelerator.com/platform/latest/#!/guide/Layouts,_Positioning,_and_the_View_Hierarchy-section-src-29004895_safe-id-TGF5b3V0cyxQb3NpdGlvbmluZyxhbmR0aGVWaWV3SGllcmFyY2h5LVNldHRpbmdkZWZhdWx0dW5pdHNpbnRpYXBwLnhtbA]\r\n", "attachment": [], "flagged": false, "summary": "Windows: Support for dp in ti.ui.defaultunit", "creator": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "subtasks": [], "reporter": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "environment": null, "closedSprints": [ { "id": 1095, "state": "closed", "name": "2018 Sprint 24", "startDate": "2018-11-19T05:35:58.310Z", "endDate": "2018-12-03T05:35:00.000Z", "completeDate": "2018-12-03T16:28:57.549Z", "originBoardId": 114 }, { "id": 1088, "state": "closed", "name": "2018 Sprint 22", "startDate": "2018-10-21T23:20:52.653Z", "endDate": "2018-11-04T23:20:00.000Z", "completeDate": "2018-11-04T23:29:59.423Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "431650", "author": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "body": "It turns out TIMOB-19350 should have taken care of this but it was not actually working. I also noticed that the default {{tiapp.xml}} that CLI produces with {{appc new}} sets {{dp}} for default {{ti.ui.defaultunit}}, which will cause problem because we have been using {{px}} for default unit for Windows. \r\n\r\nSo if you implement this feature, you should see breaking changes regarding view size ({{px}} to {{dp}}) for most of apps. For instance when you have a view with {{width: 100}}, we have treated it as {{100px}}, but because you have {{ti.ui.defaultunit=dp}} in default template, it will be treated it as {{100dp}}. I'm not sure how we should treat this without causing breaking change.\r\n", "updateAuthor": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2017-12-04T08:38:10.000+0000", "updated": "2017-12-04T13:14:30.000+0000" }, { "id": "443131", "author": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "body": "https://github.com/appcelerator/titanium_mobile_windows/pull/1300", "updateAuthor": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2018-10-31T13:53:08.000+0000", "updated": "2018-10-31T13:53:08.000+0000" }, { "id": "443745", "author": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "body": "FR passed, waiting on Jenkins build.", "updateAuthor": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-11-19T13:37:36.000+0000", "updated": "2018-11-19T13:37:36.000+0000" }, { "id": "443763", "author": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "body": "Could someone update customers about this breaking change in 8.0.0? [~aislam] \r\n\r\nThis is adding support for *dp* in *ti.ui.defaultunit*. This means this will introduce breaking change on view sizes because our tiapp.xml default unit has been set to dp but we've been using px implicitly for Windows default unit. So in order to keep consistency between previous versions, you will need to set ~px~ explicitly in tiapp.xml.", "updateAuthor": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2018-11-20T01:52:41.000+0000", "updated": "2018-11-20T01:52:41.000+0000" }, { "id": "443779", "author": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Closing ticket. Verified fix in SDK version 8.0.0.v20181120013506.\r\n\r\nTest and other information can be found at: \r\nhttps://github.com/appcelerator/titanium_mobile_windows/pull/1300", "updateAuthor": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-11-20T11:54:19.000+0000", "updated": "2018-11-20T11:54:19.000+0000" } ], "maxResults": 6, "total": 6, "startAt": 0 } } }