{ "id": "172548", "key": "TIMOB-26514", "fields": { "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "20238", "description": "", "name": "Release 7.5.0", "archived": false, "released": true, "releaseDate": "2018-11-15" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2018-11-07T00:31:43.000+0000", "created": "2018-11-02T23:43:46.000+0000", "priority": { "name": "Medium", "id": "3" }, "labels": [ "actionbar", "android", "orientation", "theme", "toolbar" ], "versions": [ { "id": "20238", "description": "", "name": "Release 7.5.0", "archived": false, "released": true, "releaseDate": "2018-11-15" } ], "issuelinks": [], "assignee": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "updated": "2018-11-07T23:19:38.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" } ], "description": "*Summary:*\r\nWhen applying a custom theme to an Android app or activity, the theme applied to an {{ActionBar}} or {{Toolbar}} title is lost when changing app orientation. It ends up resetting back to the default theme.\r\n\r\nThis bug was introduced into 7.5.0.RC.\r\n\r\n*Steps to reproduce:*\r\n# Download \"kitchensink-v2\" project from: [here|https://github.com/appcelerator/kitchensink-v2]\r\n# Set up project to build with 7.5.0.RC.\r\n# Build and run to an Android device.\r\n# Clear the alert dialog displayed on app startup.\r\n# Notice that the top ActionBar title has white text.\r\n# Rotate the device from portrait to landscape.\r\n# Notice that the top ActionBar title now has black text. (This is the bug.)\r\n\r\n*Result:*\r\nBefore rotating device. Notice the title text is white.\r\n !Good.png|thumbnail!\r\n\r\nAfter rotating, notice the title is now black. This is the bug.\r\n_(The white gap on left side is an Android P notch, which can't be captured. This is not an issue.)_\r\n !Bad.png|thumbnail! \r\n\r\n*Cause:*\r\nThe new [TiToolbarStyleHandler.java|https://github.com/appcelerator/titanium_mobile/blob/master/android/titanium/src/java/org/appcelerator/titanium/view/TiToolbarStyleHandler.java] class added to 7.5.0.RC is hard-coded to use the \"style.Widget_AppCompat_Toolbar\" theme. We need to find a way to acquire the theme resource ID applied to the activity and use that instead. This will solve it for the {{ActionBar}} as well since it's internally implemented as a {{Toolbar}} on Google's end.\r\n", "attachment": [ { "id": "65804", "filename": "Bad.png", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-11-02T23:47:00.000+0000", "size": 68273, "mimeType": "image/png" }, { "id": "65803", "filename": "Good.png", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-11-02T23:47:00.000+0000", "size": 78192, "mimeType": "image/png" } ], "flagged": false, "summary": "Android: Custom theme applied to ActionBar/Toolbar title is lost when changing orientation as of 7.5.0.RC", "creator": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "subtasks": [], "reporter": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "environment": null, "comment": { "comments": [ { "id": "443335", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "body": "PR (master): https://github.com/appcelerator/titanium_mobile/pull/10431\r\nPR (7.5.x): https://github.com/appcelerator/titanium_mobile/pull/10432", "updateAuthor": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-11-06T22:49:02.000+0000", "updated": "2018-11-06T22:49:02.000+0000" }, { "id": "443336", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "FR Passed.\r\nPR Merged.", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-11-07T00:31:39.000+0000", "updated": "2018-11-07T00:31:39.000+0000" }, { "id": "443387", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Verified the fix in SDK 7.5.0.v20181107142952.\r\nClosing.", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-11-07T23:19:32.000+0000", "updated": "2018-11-07T23:19:32.000+0000" } ], "maxResults": 3, "total": 3, "startAt": 0 } } }