{ "id": "172585", "key": "TIMOB-26539", "fields": { "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "19882", "name": "Release 8.0.0", "archived": false, "released": true, "releaseDate": "2019-03-14" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2018-11-29T18:36:12.000+0000", "created": "2018-11-09T04:02:33.000+0000", "priority": { "name": "Low", "id": "4" }, "labels": [ "android", "breaking-change", "font", "label", "parity", "unit" ], "versions": [], "issuelinks": [], "assignee": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "updated": "2018-11-30T12:17:09.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" } ], "description": "*Summary:*\r\nAndroid's {{Ti.UI.Label}} is currently hard-coded to a font size of {{15}} using the \"tiapp.xml\" property's \"ti.ui.defaultunit\". The problem with this is if you set the default unit to pixels (ie: {{px}}), then the label will default to \"15px\" and be too small to read on high DPI devices. The label's default font size should be hard-coded to \"dp\".\r\n\r\nWe don't have this issue with any of our other UI features such as {{Button}}, {{TextField}}, {{Picker}}, etc. All other UI elements use \"dp\" by default. Only our Android {{Label}} has this problem.\r\n\r\niOS does not have this problem.\r\n\r\n*Steps to reproduce:*\r\n# Create a Titanium classic app.\r\n# Set up the \"tiapp.xml\" file's default unit to \"px\" (pixels) as shown below.\r\n# Use the \"app.js\" below.\r\n# Build and run on an Android device that is xxhdpi or higher.\r\n# Notice that the text is very tiny. _(This is the bug.)_\r\n\r\ntiapp.xml\r\n{code:xml}\r\n\r\n\tpx\r\n\r\n{code}\r\n\r\napp.js\r\n{code:javascript}\r\nvar window = Ti.UI.createWindow();\r\nwindow.add(Ti.UI.createLabel({ text: \"Hello World\" }));\r\nwindow.open();\r\n{code}\r\n\r\n*Android Results:*\r\n !Android-dp.png|thumbnail! !Android-px.png|thumbnail! \r\n\r\n*iOS Results:*\r\n !ios-dp.png|thumbnail! !ios-px.png|thumbnail! \r\n\r\n", "attachment": [ { "id": "65840", "filename": "Android-dp.png", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-11-09T04:01:04.000+0000", "size": 43232, "mimeType": "image/png" }, { "id": "65841", "filename": "Android-px.png", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-11-09T04:01:04.000+0000", "size": 40168, "mimeType": "image/png" }, { "id": "65838", "filename": "ios-dp.png", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-11-09T04:01:04.000+0000", "size": 101022, "mimeType": "image/png" }, { "id": "65839", "filename": "ios-px.png", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-11-09T04:01:04.000+0000", "size": 101117, "mimeType": "image/png" } ], "flagged": false, "summary": "Android: Label's default font size should be \"dp\" unless explicitly set", "creator": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "subtasks": [], "reporter": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "environment": null, "closedSprints": [ { "id": 1093, "state": "closed", "name": "2018 Sprint 23", "startDate": "2018-11-04T23:35:52.006Z", "endDate": "2018-11-18T23:35:00.000Z", "completeDate": "2018-11-19T05:30:34.338Z", "originBoardId": 114 }, { "id": 1095, "state": "closed", "name": "2018 Sprint 24", "startDate": "2018-11-19T05:35:58.310Z", "endDate": "2018-12-03T05:35:00.000Z", "completeDate": "2018-12-03T16:28:57.549Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "443454", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "body": "PR (master): https://github.com/appcelerator/titanium_mobile/pull/10450", "updateAuthor": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-11-09T04:57:14.000+0000", "updated": "2018-11-09T04:57:14.000+0000" }, { "id": "443714", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "FR Passed.\r\nWaiting for CR to merge.", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-11-17T00:20:24.000+0000", "updated": "2018-11-17T00:20:24.000+0000" }, { "id": "444058", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "PR Merged.", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-11-29T18:36:08.000+0000", "updated": "2018-11-29T18:36:08.000+0000" }, { "id": "444092", "author": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "body": "*Closing ticket* Fix verified in SDK Version {{8.0.0.v20181129161342}}.\r\n\r\nTest and other information can be found at: \r\nhttps://github.com/appcelerator/titanium_mobile/pull/10450", "updateAuthor": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-11-30T12:16:51.000+0000", "updated": "2018-11-30T12:16:51.000+0000" } ], "maxResults": 4, "total": 4, "startAt": 0 } } }