{ "id": "172849", "key": "TIMOB-26719", "fields": { "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "19882", "name": "Release 8.0.0", "archived": false, "released": true, "releaseDate": "2019-03-14" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2019-01-15T00:32:18.000+0000", "created": "2019-01-12T04:53:53.000+0000", "priority": { "name": "High", "id": "2" }, "labels": [ "ListView", "android", "height", "regression", "row" ], "versions": [ { "id": "19882", "name": "Release 8.0.0", "archived": false, "released": true, "releaseDate": "2019-03-14" } ], "issuelinks": [], "assignee": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "updated": "2019-01-15T15:01:05.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" } ], "description": "*Summary:*\r\n{{ListView}} rows are supposed to have a default height if the template doesn't have one. On Android, the default height used to be {{45dp}} (assigned [here|https://github.com/appcelerator/titanium_mobile/blob/master/android/modules/ui/src/java/ti/modules/titanium/ui/widget/listview/TiDefaultListViewTemplate.java#L90]). As of Titanium 8.0.0, the default height is no longer being applied and the rows are auto-sizing to fit the height of the row's contents instead.\r\n\r\n*Steps to reproduce:*\r\n# Build and run the below code on Android.\r\n# Notice that the rows just-fit the height of the row text. (This is the problem.)\r\n\r\n{code:javascript}\r\nfunction createListViewSectionItems() {\r\n\tvar items = [];\r\n\tfor (var index = 1; index <= 100; index++) {\r\n\t\titems.push({ properties: { title: \"Row \" + index } });\r\n\t}\r\n\treturn items;\r\n}\r\n\r\nvar window = Ti.UI.createWindow();\r\nwindow.add(Ti.UI.createListView({\r\n\tsections: [Ti.UI.createListSection({\r\n\t\theaderTitle: \"ListView\",\r\n\t\titems: createListViewSectionItems(),\r\n\t})],\r\n}));\r\nwindow.open();\r\n{code}\r\n\r\n*Result:*\r\n !ListView-bad.png|thumbnail! \r\n\r\n*Expected Result:*\r\nThis is how it used to work in Titanium 7.x.x.\r\n !ListView-good.png|thumbnail! \r\n\r\n*Note:*\r\nWe can't solve this issue by setting a min height to the row's root layout. While that would work, Titanium app developers have spoken out in the past that they don't want this behavior as can be seen in [TIMOB-19812]. We removed the min height as of Titanium 6.0.0 and we need to keep this behavior. But it's okay to apply a default height if one was not specified.\r\n", "attachment": [ { "id": "66072", "filename": "ListView-bad.png", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-01-12T04:52:10.000+0000", "size": 128277, "mimeType": "image/png" }, { "id": "66073", "filename": "ListView-good.png", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-01-12T04:52:10.000+0000", "size": 81699, "mimeType": "image/png" } ], "flagged": false, "summary": "Android: ListView no longer applying default row height", "creator": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "subtasks": [], "reporter": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "environment": null, "closedSprints": [ { "id": 1108, "state": "closed", "name": "2019 Sprint 2", "startDate": "2019-01-14T17:20:19.067Z", "endDate": "2019-01-26T17:20:00.000Z", "completeDate": "2019-01-28T17:38:11.580Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "445294", "author": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "body": "master: https://github.com/appcelerator/titanium_mobile/pull/10614\r\n8_0_X: https://github.com/appcelerator/titanium_mobile/pull/10615", "updateAuthor": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-01-14T22:11:11.000+0000", "updated": "2019-01-14T22:11:11.000+0000" }, { "id": "445298", "author": { "name": "kmahalingam", "key": "kmahalingam", "displayName": "Keerthi Mahalingam", "active": false, "timeZone": "America/Los_Angeles" }, "body": "FR Passed.", "updateAuthor": { "name": "kmahalingam", "key": "kmahalingam", "displayName": "Keerthi Mahalingam", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2019-01-15T00:10:26.000+0000", "updated": "2019-01-15T00:10:26.000+0000" }, { "id": "445321", "author": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Closing ticket, Verified fix in SDK Version {{8.1.0.v20190115054502}} and SDK version {{8.0.0.v20190114160512}}.\r\n\r\nTest and other information can be found at: \r\nmaster: https://github.com/appcelerator/titanium_mobile/pull/10614\r\n8_0_X: https://github.com/appcelerator/titanium_mobile/pull/10615", "updateAuthor": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-01-15T15:00:47.000+0000", "updated": "2019-01-15T15:00:47.000+0000" } ], "maxResults": 4, "total": 4, "startAt": 0 } } }