{ "id": "173707", "key": "TIMOB-27126", "fields": { "issuetype": { "id": "2", "description": "A new feature of the product, which has yet to be developed.", "name": "New Feature", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "20827", "name": "Release 8.2.0", "archived": false, "released": true, "releaseDate": "2019-09-19" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2019-09-09T10:17:49.000+0000", "created": "2019-06-03T23:48:01.000+0000", "epic": { "id": 173691, "key": "TIMOB-27114", "name": "Support iOS 13", "summary": "iOS: Support iOS 13 and Xcode 11", "color": { "key": "color_3" }, "done": false }, "priority": { "name": "None", "id": "6" }, "labels": [], "versions": [], "issuelinks": [], "assignee": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "updated": "2019-09-10T16:26:58.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [], "description": "Apple announced dark mode in iOS 13. Look for apis to support in SDK. WWDC 2019 video for dark mode support - https://developer.apple.com/videos/play/wwdc2019/214/", "attachment": [], "flagged": false, "summary": "iOS 13: Support dark mode", "creator": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "subtasks": [], "reporter": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "environment": null, "closedSprints": [ { "id": 1161, "state": "closed", "name": "2019 Sprint 18", "startDate": "2019-08-26T21:46:26.269Z", "endDate": "2019-09-08T21:46:00.000Z", "completeDate": "2019-09-09T20:39:58.761Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "448804", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "Dark mode is made via the asset catalog. Having semantic colors and images is the key here. I have a local plugin running that could even generate this cross platform, so maybe it could be a an SDK extension as well.", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2019-06-04T05:29:09.000+0000", "updated": "2019-06-05T22:34:34.000+0000" }, { "id": "448841", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "Required CLI hook + native bridge: https://github.com/hansemannn/titanium-dark-mode\r\nPull request: https://github.com/appcelerator/titanium_mobile/pull/10937\r\n\r\nThe CLI hook and bridge could eventually be moved to the SDK, but this way it's a bit more flexible for developers right now.", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2019-06-05T03:55:40.000+0000", "updated": "2019-06-05T03:55:40.000+0000" }, { "id": "450183", "author": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "body": "master: https://github.com/appcelerator/titanium_mobile/pull/11097", "updateAuthor": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "created": "2019-07-31T14:49:56.000+0000", "updated": "2019-07-31T14:49:56.000+0000" }, { "id": "451065", "author": { "name": "kmahalingam", "key": "kmahalingam", "displayName": "Keerthi Mahalingam", "active": false, "timeZone": "America/Los_Angeles" }, "body": "FR passed. tested with the sample app here .https://github.com/ewanharris/darkmode-example. PR #10937 is merged. waiting on Jenkins for other PR", "updateAuthor": { "name": "kmahalingam", "key": "kmahalingam", "displayName": "Keerthi Mahalingam", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2019-09-03T20:52:35.000+0000", "updated": "2019-09-04T18:05:40.000+0000" }, { "id": "451066", "author": { "name": "kmahalingam", "key": "kmahalingam", "displayName": "Keerthi Mahalingam", "active": false, "timeZone": "America/Los_Angeles" }, "body": "PR merged", "updateAuthor": { "name": "kmahalingam", "key": "kmahalingam", "displayName": "Keerthi Mahalingam", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2019-09-03T21:04:42.000+0000", "updated": "2019-09-03T21:04:42.000+0000" }, { "id": "451111", "author": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Verified feature in SDK version {{8.2.0.v20190904142953}}. One thing I noticed is that images on the tabGroup do not change automatically when switching from light and dark mode unlike an imageVIew do, to see the image change on the tabGroup an app restart is needed. Is this an intended [~eharris]?. ", "updateAuthor": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-09-05T10:28:33.000+0000", "updated": "2019-09-05T10:28:33.000+0000" }, { "id": "451180", "author": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "body": "[~smohammed] It's not intended. Let me check on this.", "updateAuthor": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-09-06T18:15:30.000+0000", "updated": "2019-09-06T18:15:30.000+0000" }, { "id": "451183", "author": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "body": "[~kmahalingam] [~smohammed] PR for above fix -\r\n\r\nPR - https://github.com/appcelerator/titanium_mobile/pull/11200", "updateAuthor": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-09-06T19:35:02.000+0000", "updated": "2019-09-06T19:35:02.000+0000" }, { "id": "451185", "author": { "name": "kmahalingam", "key": "kmahalingam", "displayName": "Keerthi Mahalingam", "active": false, "timeZone": "America/Los_Angeles" }, "body": "FR passed.", "updateAuthor": { "name": "kmahalingam", "key": "kmahalingam", "displayName": "Keerthi Mahalingam", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2019-09-06T21:07:09.000+0000", "updated": "2019-09-06T21:07:09.000+0000" }, { "id": "451206", "author": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "body": "*Closing ticket* New feature verified in SDK version 8.2.0.v20190906140307.\r\n\r\nTest and other information can be found at:\r\nhttps://github.com/appcelerator/titanium_mobile/pull/11200\r\nhttps://github.com/appcelerator/titanium_mobile/pull/10937\r\nhttps://github.com/hansemannn/titanium-dark-mode\r\nhttps://github.com/ewanharris/darkmode-example", "updateAuthor": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-09-09T10:17:44.000+0000", "updated": "2019-09-09T10:17:44.000+0000" }, { "id": "451264", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "A few remaining questions for parity:\r\n\r\n1. Does it handle the alpha fallback for iOS < 13 and Android already, e.g. the ARGB conversion?\r\n2. Are there plans to properly support Android, e.g. the {{userInterfaceStyle}} property? ", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2019-09-10T16:26:58.000+0000", "updated": "2019-09-10T16:26:58.000+0000" } ], "maxResults": 12, "total": 12, "startAt": 0 } } }