{
"id": "174000",
"key": "TIMOB-27325",
"fields": {
"issuetype": {
"id": "1",
"description": "A problem which impairs or prevents the functions of the product.",
"name": "Bug",
"subtask": false
},
"project": {
"id": "10153",
"key": "TIMOB",
"name": "Titanium SDK/CLI",
"projectCategory": {
"id": "10100",
"description": "Titanium and related SDKs used in application development",
"name": "Client"
}
},
"fixVersions": [
{
"id": "20033",
"name": "Release 9.0.0",
"archived": false,
"released": true,
"releaseDate": "2020-03-18"
}
],
"resolution": {
"id": "1",
"description": "A fix for this issue is checked into the tree and tested.",
"name": "Fixed"
},
"resolutiondate": "2020-01-10T15:19:42.000+0000",
"created": "2019-08-09T02:56:59.000+0000",
"priority": {
"name": "Low",
"id": "4"
},
"labels": [
"android",
"cb-tooling",
"engSchedule",
"library",
"manifest",
"tiapp.xml",
"xml"
],
"versions": [],
"issuelinks": [],
"assignee": {
"name": "jquick",
"key": "jquick",
"displayName": "Joshua Quick",
"active": true,
"timeZone": "America/Los_Angeles"
},
"updated": "2020-01-10T15:19:42.000+0000",
"status": {
"description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.",
"name": "Closed",
"id": "6",
"statusCategory": {
"id": 3,
"key": "done",
"colorName": "green",
"name": "Done"
}
},
"components": [
{
"id": "10202",
"name": "Android",
"description": "Android Platform"
}
],
"description": "*Summary:*\r\nAdding a {{}} element within the \"tiapp.xml\" file's {{}} block will create an invalid entry within the generated \"AndroidManifest.xml\" when doing a build.\r\n\r\n*Note:*\r\nThe {{}} entry is supposed to go within the {{}} block, not the {{}} block. So, doing this would have been invalid anyways. This makes this bug a very minor issue.\r\nhttps://developer.android.com/guide/topics/manifest/uses-library-element\r\n\r\n*Steps to reproduce:*\r\n# Setting a project's \"tiapp.xml\" with the {{}} entry below.\r\n# Build the project.\r\n# Open Finder or Window Explorer.\r\n# Go to project's subdirectory: {{./build/android}}\r\n# Open the \"AndroidManifest.xml\" file.\r\n\r\n{code:xml}\r\n\r\n\r\n\t\r\n\t\t\r\n\t\t\t\r\n\t\t\r\n\t\r\n\r\n{code}\r\n\r\n*Result:*\r\nThe following invalid XML element can be found within the \"AndroidManifest.xml\" file. This doesn't prevent the app from running, but it's still not good that this is there.\r\n{code:xml}\r\n[object Object]\r\n{code}\r\n\r\n*Expected Result:*\r\nBuild system should either omit the {{}} entry or add it as-is.\r\n\r\n*Solution:*\r\nAs noted above, the {{}} is supposed to go within the {{}} block. So, all Titanium app devs should be doing the following instead. The build system will correctly inject this into the \"AndroidManifest.xml\" file.\r\n{code:xml}\r\n\r\n\r\n\t\r\n\t\t\r\n\t\t\t\r\n\t\t\t\t\r\n\t\t\t\r\n\t\t\r\n\t\r\n\r\n{code}\r\n",
"attachment": [],
"flagged": false,
"summary": "Android: Adding within \"tiapp.xml\" file's block creates invalid entry in \"AndroidManifest.xml\"",
"creator": {
"name": "jquick",
"key": "jquick",
"displayName": "Joshua Quick",
"active": true,
"timeZone": "America/Los_Angeles"
},
"subtasks": [],
"reporter": {
"name": "jquick",
"key": "jquick",
"displayName": "Joshua Quick",
"active": true,
"timeZone": "America/Los_Angeles"
},
"environment": null,
"closedSprints": [
{
"id": 1175,
"state": "closed",
"name": "2019 Sprint 26",
"startDate": "2019-12-16T06:12:12.044Z",
"endDate": "2019-12-21T06:12:00.000Z",
"completeDate": "2019-12-22T03:07:15.802Z",
"originBoardId": 114
}
],
"comment": {
"comments": [
{
"id": "451752",
"author": {
"name": "cbarber",
"key": "cbarber",
"displayName": "Chris Barber",
"active": true,
"timeZone": "America/Chicago"
},
"body": "I think this is as simple as removing {{}} as a valid tag name under the {{}}:\r\n\r\nhttps://github.com/appcelerator/titanium_mobile/blob/master/android/cli/lib/AndroidManifest.js#L376\r\nand\r\nhttps://github.com/appcelerator/titanium_mobile/blob/master/android/cli/lib/AndroidManifest.js#L558",
"updateAuthor": {
"name": "cbarber",
"key": "cbarber",
"displayName": "Chris Barber",
"active": true,
"timeZone": "America/Chicago"
},
"created": "2019-10-02T05:09:06.000+0000",
"updated": "2019-10-02T05:09:23.000+0000"
},
{
"id": "453197",
"author": {
"name": "gmathews",
"key": "gmathews",
"displayName": "Gary Mathews",
"active": true,
"timeZone": "America/Los_Angeles"
},
"body": "[~jquick] I see this is _In QE Testing_, is there a PR for this?",
"updateAuthor": {
"name": "gmathews",
"key": "gmathews",
"displayName": "Gary Mathews",
"active": true,
"timeZone": "America/Los_Angeles"
},
"created": "2019-12-16T18:19:37.000+0000",
"updated": "2019-12-16T18:19:37.000+0000"
},
{
"id": "453203",
"author": {
"name": "jquick",
"key": "jquick",
"displayName": "Joshua Quick",
"active": true,
"timeZone": "America/Los_Angeles"
},
"body": "PR (master): https://github.com/appcelerator/titanium_mobile/pull/11339\r\n\r\n[~gmathews], sorry about that. The above gradle PR solves it because the \"AndroidManifest.xml\" is merged/validated by Google's build tools. There is already a test written on that PR verifying that this issue will (rightfully) trigger a build failure.",
"updateAuthor": {
"name": "jquick",
"key": "jquick",
"displayName": "Joshua Quick",
"active": true,
"timeZone": "America/Los_Angeles"
},
"created": "2019-12-16T20:20:23.000+0000",
"updated": "2019-12-16T20:20:23.000+0000"
},
{
"id": "453274",
"author": {
"name": "lchoudhary",
"key": "lchoudhary",
"displayName": "Lokesh Choudhary",
"active": true,
"timeZone": "America/Los_Angeles"
},
"body": "FR Passed.\r\nPR Merged.",
"updateAuthor": {
"name": "lchoudhary",
"key": "lchoudhary",
"displayName": "Lokesh Choudhary",
"active": true,
"timeZone": "America/Los_Angeles"
},
"created": "2019-12-20T23:57:21.000+0000",
"updated": "2019-12-20T23:57:21.000+0000"
},
{
"id": "453636",
"author": {
"name": "smohammed",
"key": "smohammed",
"displayName": "Samir Mohammed",
"active": true,
"timeZone": "America/Los_Angeles"
},
"body": "Closing ticket, fix verified in SDK Version {{9.0.0.v20200109153329}}.\r\n\r\nTest and other information can be found at: \r\nhttps://github.com/appcelerator/titanium_mobile/pull/11339",
"updateAuthor": {
"name": "smohammed",
"key": "smohammed",
"displayName": "Samir Mohammed",
"active": true,
"timeZone": "America/Los_Angeles"
},
"created": "2020-01-10T15:19:32.000+0000",
"updated": "2020-01-10T15:19:32.000+0000"
}
],
"maxResults": 7,
"total": 7,
"startAt": 0
}
}
}