{ "id": "63438", "key": "TIMOB-2806", "fields": { "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "11238", "name": "Release 1.6.0 M05", "archived": true, "released": true, "releaseDate": "2011-01-17" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2011-04-17T02:00:08.000+0000", "created": "2011-04-15T03:30:00.000+0000", "priority": { "name": "Medium", "id": "3" }, "labels": [ "android", "defect", "release-1.6.0", "reported-1.5.1" ], "versions": [], "issuelinks": [], "assignee": { "name": "mculpepper", "key": "mculpepper", "displayName": "Marshall Culpepper", "active": true, "timeZone": "America/Los_Angeles" }, "updated": "2011-04-17T02:00:08.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" } ], "description": "{html}
Reproduce:
\njar tf [jarfile]
and\nunzip -l [zipfile]
to confirm that the asset file was\nnot put anywhere.Marshall,
\nHave a look at this diff:
\n\ndiff --git a/support/module/android/build.xml b/support/module/android/build.xml\nindex 3e51233..dd46c51 100644\n--- a/support/module/android/build.xml\n+++ b/support/module/android/build.xml\n@@ -71,7 +71,10 @@\n <target name=\"dist\" depends=\"compile\" description=\"Generate a distributable module JAR\">\n <ti.string property=\"module.id\" string=\"${manifest.moduleid}\" tolowercase=\"true\"/>\n <property name=\"module.jar\" location=\"${dist}/${ant.project.name}.jar\"/>\n- <jar destfile=\"${module.jar}\" basedir=\"${classes}\"/>\n+ <jar destfile=\"${module.jar}\">\n+ <fileset dir=\"${classes}\"/>\n+ <fileset dir=\"${ti.module.root}\" includes=\"assets/**\" excludes=\"assets/README\"/>\n+ </jar>\n <property name=\"zip.prefix\" value=\"modules/android/${module.id}/${manifest.version}\"/>\n \n <zip destfile=\"${dist}/${module.id}-android-${manifest.version}.zip\">
\n
\n(Pretty version: https://skitch.com/billdawson/rjnfb/timobile-bash-125x25).
\nI didn't want to commit anything without checking with you. This\nchange achieves just what I wanted: the ability to use\ngetClass().getClassLoader().getResourceAsStream(\"assets/xxxx.png\");
,\nbut I'm not sure if that's the way you intended the\nassets/
folder to be used.
Thx,
\nBill
Putting this in 1.6 since it's a pretty big deal, but haven't\nassigned a milestone for it -- I'll let marshall/don choose.
Hey Bill.. this looks right, feel free to push it
(from [70ff1a5d3829e972fe137db914821e0cec4f348d])\n[#2806 state:fixed-in-qa] patch module build.xml\nto include assets folder contents \nhttps://github.com/appcelerator/titanium_mobile/commit/70ff1a5d3829...
(from [71e5697df121928e2d3ebe5934ee503236a3ced9])\n[#2806 state:fixed-in-qa] patch module build.xml\nto include assets folder contents \nhttps://github.com/appcelerator/titanium_mobile/commit/71e5697df121...
verified assets bundling works with new and existing module\nprojects