{ "id": "175445", "key": "TIMOB-28086", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "21050", "name": "Release 10.0.0", "archived": false, "released": true, "releaseDate": "2021-05-17" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2021-03-05T15:57:21.000+0000", "created": "2020-08-17T23:21:48.000+0000", "epic": { "id": 175923, "key": "TIMOB-28298", "name": "Android: Material widget support", "summary": "Android: Material widget support", "color": { "key": "color_1" }, "done": false }, "priority": { "name": "Medium", "id": "3" }, "labels": [ "2020-Q4", "android", "breaking-change", "material-theme", "theme", "toolbar" ], "versions": [], "issuelinks": [ { "id": "58633", "type": { "id": "10020", "name": "Depends", "inward": "is dependent of", "outward": "depends on" }, "inwardIssue": { "id": "173001", "key": "TIMOB-26825", "fields": { "summary": "Android: Add AppBarLayout support", "status": { "description": "The issue is open and ready for the assignee to start work on it.", "name": "Open", "id": "1", "statusCategory": { "id": 2, "key": "new", "colorName": "blue-gray", "name": "To Do" } }, "priority": { "name": "Low", "id": "4" }, "issuetype": { "id": "2", "description": "A new feature of the product, which has yet to be developed.", "name": "New Feature", "subtask": false } } } } ], "assignee": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "updated": "2021-03-05T15:57:21.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" } ], "description": "*Summary:*\r\nOur [Ti.UI.Toolbar|https://docs.appcelerator.com/platform/latest/#!/api/Titanium.UI.Toolbar] is currently using the Java [androidx.appcompat.widget.Toolbar|https://developer.android.com/reference/androidx/appcompat/widget/Toolbar] class. It should be updated to use the newer [MaterialToolbar|https://developer.android.com/reference/com/google/android/material/appbar/MaterialToolbar] class. The newer class supports the material theme.\r\n\r\nIn the future, it can also be used by an [AppBarLayout|https://developer.android.com/reference/com/google/android/material/appbar/AppBarLayout] as described by ticket [TIMOB-26825] which allows the top to be hidden within a {{ScrollView}} while scrolling.\r\n\r\n*To-Do:*\r\nWe must replace our usage below...\r\n* [TiToolbar.java|https://github.com/appcelerator/titanium_mobile/blob/master/android/modules/ui/src/java/ti/modules/titanium/ui/widget/TiToolbar.java]\r\n* [titanium_ui_drawer_layout.xml|https://github.com/appcelerator/titanium_mobile/blob/master/android/modules/ui/res/layout/titanium_ui_drawer_layout.xml]\r\n* [titanium_ui_toolbar.xml|https://github.com/appcelerator/titanium_mobile/blob/master/android/modules/ui/res/layout/titanium_ui_toolbar.xml]\r\n\r\n*Breaking-Change:*\r\nThe app must use a \"Theme.MaterialComponents\" based theme or else an exception will occur. So, app's using a custom theme based from \"Theme.AppCompat\" or similar will crash. This is normal and the exception will state that the theme will need to change.", "attachment": [], "flagged": false, "summary": "Android: Update \"Toolbar\" to support material theme", "creator": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "subtasks": [], "reporter": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "environment": null, "comment": { "comments": [ { "id": "457940", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "body": "PR (master): https://github.com/appcelerator/titanium_mobile/pull/12353", "updateAuthor": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2020-12-19T10:03:01.000+0000", "updated": "2020-12-19T10:03:01.000+0000" }, { "id": "458337", "author": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "body": "FR Passed, waiting on Jenkins build and backport", "updateAuthor": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2021-03-04T14:26:47.000+0000", "updated": "2021-03-04T14:26:47.000+0000" }, { "id": "458349", "author": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "body": "merged to master and 10_0_X for 10.0.0 release target.", "updateAuthor": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "created": "2021-03-05T15:57:18.000+0000", "updated": "2021-03-05T15:57:18.000+0000" } ], "maxResults": 3, "total": 3, "startAt": 0 } } }