{ "id": "175924", "key": "TIMOB-28299", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "21050", "name": "Release 10.0.0", "archived": false, "released": true, "releaseDate": "2021-05-17" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2021-03-05T15:57:14.000+0000", "created": "2020-12-19T04:16:59.000+0000", "epic": { "id": 175923, "key": "TIMOB-28298", "name": "Android: Material widget support", "summary": "Android: Material widget support", "color": { "key": "color_1" }, "done": false }, "priority": { "name": "Medium", "id": "3" }, "labels": [ "TextArea", "TextField", "android", "breaking-change", "material-design", "material-theme", "theme" ], "versions": [], "issuelinks": [], "assignee": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "updated": "2021-03-05T15:57:14.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" } ], "description": "*Summary:*\r\nOur {{Ti.UI.TextField}} and {{Ti.UI.TextArea}} views currently use the old holo theme which only shows an underline. We should update them to support the new material theme \"filled\" and \"outlined\" styles as shown below.\r\nhttps://material.io/components/text-fields\r\n\r\n*To-Do:*\r\nAdd the iOS-only [borderStyle|https://docs.appcelerator.com/platform/latest/#!/api/Titanium.UI.TextField-property-borderStyle] property to Android's {{TextField}} and {{TextArea}} views. This gives us access to the following constants.\r\n* Ti.UI.INPUT_BORDERSTYLE_BEZEL // iOS only inset frame.\r\n* Ti.UI.INPUT_BORDERSTYLE_LINE // Rectangular border.\r\n* Ti.UI.INPUT_BORDERSTYLE_NONE // No border.\r\n* Ti.UI.INPUT_BORDERSTYLE_ROUNDED // Rounded rectangle border.\r\n\r\nWe should also add the following Android-only border style constants.\r\n* Ti.UI.INPUT_BORDERSTYLE_FILLED // Android-only. The default material theme.\r\n* Ti.UI.INPUT_BORDERSTYLE_UNDERLINED // Only Android holo theme.\r\n\r\nWe should change {{TextField}} and {{TextArea}} to default to the FILLED style since that's what is documented by Google's material theme guidelines.\r\n\r\n*Test Code:*\r\nThis can be tested with the attached [^TextFieldBorderTest.js] script which will displays what's shown in the below screenshots.\r\n !TextField-Android-Light.png|thumbnail! !TextField-Android-Dark.png|thumbnail! !TextField-iOS.png|thumbnail! \r\n\r\n*Breaking-Change:*\r\nThe app must use a \"Theme.MaterialComponents\" based theme or else an exception will occur. So, app's using a custom theme based from \"Theme.AppCompat\" or similar will crash. This is normal and the exception will state that the theme will need to change.\r\n", "attachment": [ { "id": "67807", "filename": "TextField-Android-Dark.png", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2021-02-23T02:39:36.000+0000", "size": 483176, "mimeType": "image/png" }, { "id": "67806", "filename": "TextField-Android-Light.png", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2021-02-23T02:39:36.000+0000", "size": 472133, "mimeType": "image/png" }, { "id": "67808", "filename": "TextFieldBorderTest.js", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2021-02-23T02:41:19.000+0000", "size": 1603, "mimeType": "application/x-javascript" }, { "id": "67805", "filename": "TextField-iOS.png", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2021-02-23T02:39:36.000+0000", "size": 835942, "mimeType": "image/png" } ], "flagged": false, "summary": "Android: Add new material theme styles to \"TextField\" and \"TextArea\"", "creator": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "subtasks": [], "reporter": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "environment": null, "comment": { "comments": [ { "id": "457941", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "body": "PR (master): https://github.com/appcelerator/titanium_mobile/pull/12353", "updateAuthor": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2020-12-19T10:03:17.000+0000", "updated": "2020-12-19T10:03:17.000+0000" }, { "id": "458348", "author": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "body": "merged to master and 10_0_X for 10.0.0 release target.", "updateAuthor": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "created": "2021-03-05T15:57:10.000+0000", "updated": "2021-03-05T15:57:10.000+0000" } ], "maxResults": 2, "total": 2, "startAt": 0 } } }