[TIMOB-3171] Android: Response cache max size should be adjustable
| GitHub Issue | n/a |
|---|---|
| Type | New Feature |
| Priority | Medium |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2011-04-26T13:18:55.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Release 1.7.0, Sprint 2011-12 |
| Components | Android |
| Labels | android, cache, feature, release-1.7.0, reported-1.6.0, responsecache |
| Reporter | Bill Dawson |
| Assignee | Opie Cyrus |
| Created | 2011-04-15T03:38:44.000+0000 |
| Updated | 2011-04-26T13:18:55.000+0000 |
Description
The code defines private static final String
CACHE_SIZE_KEY = "ti.android.cache.size.max"; but never once
makes use of it.
Attachments
| File | Date | Size |
|---|---|---|
| tiapp.xml | 2011-04-15T03:38:44.000+0000 | 1392 |
(from [4611635381c25bc933fb18ecac3027b670814725]) [#3171 state:fixed-in-qa] utilize ti.android.cache.size.max value for setting response cache size
respect ti.android.cache.size.max value when setting response cache. also moved setting the TiConfig.LOGD value to the postOnCreate method inside TiApplication in order to support debug logging during the intialization of the response cache.
https://github.com/appcelerator/titanium_mobile/commit/4611635381c25bc933fb18ecac3027b670814725"> https://github.com/appcelerator/titanium_mobile/commit/4611635381c2...
Please verify the fix by running the default titanium test app with debug output enabled (see attached tiapp.xml). You should see a debug message "[TRACE] D/TiResponseCache( 318): (main) [254,980] max cache size is:204800" if the value in tiapp.xml is being respected.
The value in "200" within tiapp.xml is what drives the debug value printed. The value in tiapp.xml represents the max cache size in kilo bytes but the debug output value is bytes.