[TIMOB-4041] Android: Add "separatorStyle" property to Ti.UI.ListView

GitHub Issue	n/a
Type	New Feature
Priority	Low
Status	Closed
Resolution	Fixed
Resolution Date	2019-04-23T18:18:58.000+0000
Affected Version/s	Release 1.7.0, Release 1.6.2
Fix Version/s	Release 8.1.0
Components	Android
Labels	ListView, android, feature, parity
Reporter	Alan Leard
Assignee	Joshua Quick
Created	2011-05-10T20:56:44.000+0000
Updated	2019-04-23T18:18:58.000+0000

Description

Users have requested the ability to eliminate the Separator in a tableview so when they are using backgroundImages for the TableViewRow there is no break in between the rows. See screenshot: http://screencast.com/t/5lDQUpCyHpxv Setting the tableView seperatorColor to 'transparent' shows the table backgroundColor. Sample project is attached. The API should match iOS as closely as possible, so we are moving the existing iOS* constants into the top level UI namespace, and keeping the existing separatorStyle property that iOS uses. The valid styles should be: Ti.UI.TableViewSeparatorStyle.NONE Ti.UI.TableViewSeparatorStyle.SINGLE_LINE In the future we can also implement custom separator drawables by passing them to this property (Android only)

Attachments

File	Date	Size
app.js	2011-08-10T21:03:03.000+0000	1636
Archive.zip	2011-05-10T21:15:40.000+0000	2411867

Comments

Opie Cyrus 2011-08-10

test case utilizing new separatorVisible property
Stephen Tramer 2011-08-12

This ticket duplicates existing iOS functionality (Ti.UI.iPhone.TableViewSeperatorStyle.NONE) and as a result we need to have a discussion about this API point. It seems perfectly reasonable to have a Ti.UI.TableView.SEPERATOR_NONE style, or something similar. Future-proofing is a valid concern as well as compatibility with existing systems.
Marshall Culpepper 2011-09-08

Updated based on parity discussion
Hans Knöchel 2014-01-25

Seems to be "In progress" since 2011, it may be updated to the current status.
Hans Knöchel 2019-01-25

PR: https://github.com/appcelerator/titanium_mobile/pull/10648
Lokesh Choudhary 2019-04-16

PR Merged.

Keerthi Mahalingam 2019-04-23

Verified using SDK 8.1.0.v20190423074844.Works as expected..Closing.

   Test environment:
   Name                        = Mac OS X
     Version                     = 10.13.6
     Architecture                = 64bit
     # CPUs                      = 8
     Memory                      = 17179869184
   Node.js
     Node.js Version             = 8.9.1
     npm Version                 = 5.5.1
   Titanium CLI
     CLI Version                 = 5.1.1
   Titanium SDK
   SDK  =8.1.0.v20190423074844
   CLI =7.0.11-70X.1
   Device =oneplus 5t version 9
   Emulator= pixel android 8

JSON Source