Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-4445] Module build.py Always Warns About Default License

GitHub Issuen/a
TypeBug
PriorityMedium
StatusClosed
ResolutionFixed
Resolution Date2011-10-27T14:47:45.000+0000
Affected Version/sRelease 1.7.0
Fix Version/sSprint 2011-24, Release 1.8.0
ComponentsiOS
Labelsn/a
ReporterDawson Toth
AssigneeDawson Toth
Created2011-06-16T07:20:48.000+0000
Updated2011-10-27T14:47:53.000+0000

Description

Problem

The module.py in the module template always warns that the default license text is being used:
please update the LICENSE file with your license text before distributing

Fix

Line 102 of support/module/iphone/templates/build.py is wrong:
	if c.find(module_license_default)!=1:
!=1 should be !=-1

Comments

  1. Dawson Toth 2011-06-16

    Pull Request

    https://github.com/appcelerator/titanium_mobile/pull/125
  2. Dawson Toth 2011-06-16

    Test

    1. [Create a new iOS module](http://wiki.appcelerator.org/display/guides/Module+Developer+Guide+for+iOS) 2. ./build.py it 3. Notice the warning that the LICENSE has not been customized 4. Customize the LICENSE file (replace the existing content with the text "Hello, world!" 5. ./build.py it 6. If the bug is present, you will still see the warning. With the above fix, you will not see the warning.

JSON Source