[TIMOB-4779] 'location' event listener on Ti.Geolocation on Android is unreliable

   From 3d20822fcb9c4df2246b9189f463bf7e7324423b Mon Sep 17 00:00:00 2001
   From: Keith Gable <keith.gable@macrosolve.com>
   Date: Thu, 8 Dec 2011 17:35:16 -0600
   Subject: [PATCH] Hack the location helper to work better in our application:
   
   * Don't require that the location provider support bearing, speed, etc.
     when using ACCURACY_BEST.
   * Initial event listener call will listen to both the GPS and network
     providers for location.
   * Additional debugging to figure out what step the geolocation process
     is reaching before dying.
   ---
    .../titanium/util/TiLocationHelper.java            |   55 +++++++++++++------
    1 files changed, 37 insertions(+), 18 deletions(-)
   
   diff --git a/android/titanium/src/org/appcelerator/titanium/util/TiLocationHelper.java b/android/titanium/src/org/appcelerator/titanium/util/TiLocationHelper.java
   index 2d04b35..d1b930b 100644
   --- a/android/titanium/src/org/appcelerator/titanium/util/TiLocationHelper.java
   +++ b/android/titanium/src/org/appcelerator/titanium/util/TiLocationHelper.java
   @@ -48,11 +48,12 @@ public class TiLocationHelper
    
    	private static int buildUpdateFrequency(Integer frequency)
    	{
   -		if (frequency != null) {
   -			return frequency.intValue() * 1000;
   -		} else {
   -			return DEFAULT_UPDATE_FREQUENCY;
   -		}
   +	  // Updated 2011-12-05 by Keith Gable <keith.gable@macrosolve.com>:
   +	  // * Always return 0 so we get instant updates.
   +
   +    Log.i(LCAT, "Update frequency: 0");
   +
   +	  return 0;
    	}
    
    	private static float buildUpdateDistance(Integer accuracy)
   @@ -61,7 +62,10 @@ public class TiLocationHelper
    
    		if (accuracy != null) {
    			switch(accuracy.intValue()) {
   -				case ACCURACY_BEST : updateDistance = 1.0f; break;
   +			  // Updated 2011-12-05 by Keith Gable <keith.gable@macrosolve.com>:
   +			  // * ACCURACY_BEST's updateDistance is 0.0 now.
   +
   +				case ACCURACY_BEST : updateDistance = 0.0f; break;
    				case ACCURACY_NEAREST_TEN_METERS : updateDistance = 10.0f; break;
    				case ACCURACY_HUNDRED_METERS : updateDistance = 100.0f; break;
    				case ACCURACY_KILOMETER : updateDistance = 1000.0f; break;
   @@ -71,6 +75,8 @@ public class TiLocationHelper
    			}
    		}
    
   +    Log.i(LCAT, "Update distance: " + updateDistance);
   +
    		return updateDistance;
    	}
    
   @@ -83,9 +89,15 @@ public class TiLocationHelper
    			int updateFrequency = buildUpdateFrequency(frequency);
    			float updateDistance = buildUpdateDistance(accuracy);
    
   -			Log.i(LCAT, "registering listener with provider [" + provider + "], frequency [" + updateFrequency + "], distance [" + updateDistance + "]");
   +			Log.i(LCAT, "Registering location listener on network and GPS providers, frequency [" + updateFrequency + "], distance [" + updateDistance + "]");
   +
   +      // Updated 2011-12-05 by Keith Gable <keith.gable@macrosolve.com>:
   +      // * Instead of using the provider we detected, use both providers. When onLocationChanged fires in
   +      //   TiLocation.java, updateProvider will be called and then we will use the best provider. This will
   +      //   permit the app to at least get an instant location initially.
   +			locationManager.requestLocationUpdates(LocationManager.GPS_PROVIDER, updateFrequency, updateDistance, listener);
   +			locationManager.requestLocationUpdates(LocationManager.NETWORK_PROVIDER, updateFrequency, updateDistance, listener);
    
   -			locationManager.requestLocationUpdates(provider, updateFrequency, updateDistance, listener);
    			listenerCount.incrementAndGet();
    		} else {
    			Log.e(LCAT, "unable to register, provider is null");
   @@ -160,12 +172,16 @@ public class TiLocationHelper
    	{
    		String provider;
    
   -		if ((preferredProvider != null) && isValidProvider(preferredProvider)) {
   -			provider = preferredProvider;
   -		} else {
   -			Criteria criteria = createCriteria(accuracy);
   -			provider = getLocationManager().getBestProvider(criteria, true);
   -		}		
   +    // Updated 2011-12-05 by Keith Gable <keith.gable@macrosolve.com>:
   +    // * Always create criteria and get the best provider. We don't care about
   +    //   the preferred provider.
   +
   +    Log.i(LCAT, "Getting best provider...");
   +
   +		Criteria criteria = createCriteria(accuracy);
   +		provider = getLocationManager().getBestProvider(criteria, true);
   +
   +    Log.i(LCAT, "...and it is " + provider);
    
    		return provider;
    	}
   @@ -179,13 +195,16 @@ public class TiLocationHelper
    			int value = accuracy.intValue();
    
    			switch(value) {
   +			  // Updated 2011-12-05 by Keith Gable <keith.gable@macrosolve.com>:
   +			  // * ACCURACY_BEST/NEAREST_TEN_METERS/HUNDRED_METERS no longer require
   +			  //   altitude/bearing/etc.
    				case ACCURACY_BEST :
    				case ACCURACY_NEAREST_TEN_METERS :
    				case ACCURACY_HUNDRED_METERS :
   -					criteria.setAccuracy(Criteria.ACCURACY_FINE);
   -					criteria.setAltitudeRequired(true);
   -					criteria.setBearingRequired(true);
   -					criteria.setSpeedRequired(true);
   +					criteria.setAccuracy(Criteria.ACCURACY_FINE); // ACCURACY_HIGH preferred, but requires Android 2.3+
   +					criteria.setAltitudeRequired(false);
   +					criteria.setBearingRequired(false);
   +					criteria.setSpeedRequired(false);
    					break;
    				case ACCURACY_KILOMETER :
    				case ACCURACY_THREE_KILOMETERS :
   -- 
   1.7.3.4