Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-5163] iOS: Migrate Ti.Facebook.LoginButton constants to Ti.Facebook and rename

GitHub Issuen/a
TypeBug
PriorityLow
StatusClosed
ResolutionFixed
Resolution Date2012-01-05T10:41:00.000+0000
Affected Version/sRelease 1.7.2
Fix Version/sSprint 2011-46, Release 1.8.0.1
ComponentsiOS
Labelsdeprecated-1.8.0, parity, qe-testadded
ReporterStephen Tramer
AssigneeSabil Rahim
Created2011-08-29T15:08:12.000+0000
Updated2012-01-05T10:41:00.000+0000

Description

The constants on Ti.Facebook.LoginButton (STYLE_WIDE and STYLE_NORMAL) need to be: * Moved to Ti.Facebook * Renamed to BUTTON_STYLE_WIDE, BUTTON_STYLE_NORMAL Please keep the original names in for backwards compatibility in 1.9 and deprecate. ---------------------------------------------------------------------------------------------- NOTE FOR QE: While testing, its worth noting that now in Mashup/Facebook/ *login/logout & photos would show a wide faceebook button. *Query,Properties, Publish Stream show a normal facebook button. ----------------------------------------------------------------------------------------------

Attachments

FileDateSize
app.js2011-11-18T13:36:43.000+00001151

Comments

  1. Sabil Rahim 2011-11-07

    STYLE_WIDE AND STYLE_NORMAL where undocumented and unused/unusable ..Therefore instead of migrating it, it has been removed.
  2. Stephen Tramer 2011-11-07

    Should have been clearer when initially creating this issue; iOS does not support these STYLE constants; we actually needed to create them. We should replace the internal usage of "wide" and whatever other string descriptor is used to load style with these constants. Please get in touch with Android as well, to see if they have these constants floating around too, and what their values are.
  3. Sabil Rahim 2011-11-18

    Testing file Attached : "app.js"
  4. Sabil Rahim 2011-11-18

    pull pending # 734
  5. Wilson Luu 2011-12-08

    Closing bug. Verified fix on: OS: Mac OS X Lion Titanium Studio, build: 1.0.7.201112080131 SDK build: 1.8.0.1.v20111207180431 Devices: iphone 4S Sprint (5.0.1)
  6. Stephen Tramer 2011-12-09

    Reopening to add deprecation label.
  7. Michael Pettiford 2012-01-05

    Reopening/closing to add/remove labels

JSON Source