Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-559] Android: Appversion never taken from tiapp.xml

GitHub Issuen/a
TypeBug
PriorityMedium
StatusClosed
ResolutionFixed
Resolution Date2013-10-19T01:07:23.000+0000
Affected Version/sRelease 3.0.0
Fix Version/s2013 Sprint 21, 2013 Sprint 21 Core, Release 3.2.0
ComponentsAndroid, CLI, Tooling
Labelsandroidbuild, ay-verified, cb-verified, core
ReporterMetal3d
AssigneeChris Barber
Created2011-04-15T02:31:55.000+0000
Updated2013-11-13T18:34:26.000+0000

Description

I found this bug while I created new release for Android Market. appversion is never changed from tiapp.xml file (version tag). I send you patch to correct this, to apply on 1.0.0/android/android.py

Attachments

FileDateSize
android-appversion-correction.patch2011-04-15T02:31:55.000+0000903

Comments

  1. Metal3d 2011-04-15

    There is a trouble with this patch... in fact with "android" manifest if you need to specify a floating value for version. It could be cool to correct this quickly, everybody wich needs to upload a new revision on android market is blocked because the appversion need to greater than previous

  2. Stephen Tramer 2011-04-15

    Assigning to Don for triage... but bounce it back to iOS once you've handled it so we can check the report as well.

  3. Don Thorp 2011-04-15

    There is a reason the version tag isn't used, because it's not sufficient for Android. You need to specify them in the android section of the tiapp.xml in the application element. Android requires an integer version that is incremented for each release AND a string version that can be everything. I will leave it in TBS so we can discuss it, but until we get project/platform specific settings it has to be done through the android manifest.

  4. Jon Alter 2011-04-15

    Associated Helpdesk Ticket

    http://developer.appcelerator.com/helpdesk/view/76595">http://developer.appcelerator.com/helpdesk/view/76595

  5. Jon Alter 2011-08-29

    Associated Helpdesk Ticket

    http://appc.me/c/APP-835962
  6. Josh Roesslein 2012-07-26

    We still don't generate a new versionCode for the AndroidManifest.xml when the "version" in tiapp.xml is updated. As mentioned in previous comment this is mostly due to Android requiring this to be an integer. http://developer.android.com/guide/topics/manifest/manifest-element.html#vcode
  7. Chris Barber 2013-10-15

    In Titanium SDK 3.2, we will populate the "android:versionName" with the from the tiapp.xml. The "android:versionCode" will default to "1". You can override both of these values via the tiapp.xml: 
       <android>
       <manifest android:versionName="whatever" android:versionCode="1"></manifest>
   </android>
  8. Allen Yeung 2013-10-19

    PR: https://github.com/appcelerator/titanium_mobile/pull/4781
  9. Samuel Dowse 2013-11-13

    Verified fixed on: Mac OSX 10.9 Mavericks Titanium Studio, build: 3.2.0.201311122225 Titanium SDK, build: 3.2.0.v20131112144044 CLI: 3.2.0 Alloy: 1.3.0 Android version can be specified in the tiapp.xml Closing.

JSON Source