{ "id": "61306", "key": "TIMOB-674", "fields": { "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "11222", "name": "Release 1.2.0", "archived": true, "released": true, "releaseDate": "2010-04-05" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2011-04-17T01:53:52.000+0000", "created": "2011-04-15T02:34:10.000+0000", "priority": { "name": "Medium", "id": "3" }, "labels": [ "android", "defect" ], "versions": [], "issuelinks": [], "assignee": { "name": "mculpepper", "key": "mculpepper", "displayName": "Marshall Culpepper", "active": true, "timeZone": "America/Los_Angeles" }, "updated": "2011-04-17T01:53:52.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" } ], "description": "{html}
{html}", "attachment": [], "flagged": false, "summary": "Android: TableViewRow height not working.", "creator": { "name": "dthorp", "key": "dthorp", "displayName": "Don Thorp", "active": true, "timeZone": "America/Los_Angeles" }, "subtasks": [], "reporter": { "name": "dthorp", "key": "dthorp", "displayName": "Don Thorp", "active": true, "timeZone": "America/Los_Angeles" }, "environment": null, "comment": { "comments": [ { "id": "123780", "author": { "name": "mculpepper", "key": "mculpepper", "displayName": "Marshall Culpepper", "active": true, "timeZone": "America/Los_Angeles" }, "body": "{html}(from [363df2843cbbb4a3037105a2bbf900606027fba9])\nadded \"height\" support to row proxies [#674\nstate:resolved] \nhttp://github.com/appcelerator/titanium_mobile/commit/363df2843cbbb...
you sure the content measuring stuff works?....
\nh = Math.max(h, Math.max(content.getMeasuredHeight(),\nMath.max(leftImageHeight, rightImageHeight)));
\ngiven your fix (that height overrides the above), then should I\nhave expected my row to have been resized, before this fix?
\nI have a row with an images and some lables etc, the row was\nnever sized to fit them.
\nIs that a different defect - as this is specifically a fix to\ninclude support for height?
Hey Dan.. looks like I may've misunderstood the purpose of this\nbug. If the row isn't growing correctly to the content size of your\nimages/labels, then that would be a bug in the way that \"auto\"\nworks. Are you explicitly setting width/height for those rows to a\nstatic number, or just \"auto\" (which is the default)?
No you understood this bug well enough... setting an explicit\nheight had no effect.
\nMy comment above was made because when I saw the implementation\nof your fix it became clear to me that the existing code\nshould have resized the row 'auto'matically by default (I\nwasn't really aware of this before). I remembered that it wasn't\nresizing with 'auto' before.
\nSo yes there are two bugs (the second one I only became aware of\nafter reviewing your fix for the first)
\nhmm - latest pull from HEAD looks like 'auto' is behaving\nbetter, possibly correctly - perhaps there is no second bug. could\nI have been seeing auto fail because i only copied over the ui\njar.