Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-696] Android: Validate appid and Title as valid Java identifiers

GitHub Issuen/a
TypeBug
PriorityMedium
StatusClosed
ResolutionFixed
Resolution Date2011-04-17T01:53:57.000+0000
Affected Version/sn/a
Fix Version/sRelease 1.3.0
ComponentsAndroid
Labelsandroid, tooling
ReporterDon Thorp
AssigneeMarshall Culpepper
Created2011-04-15T02:34:41.000+0000
Updated2011-04-17T01:53:57.000+0000

Description

See http://developer.appcelerator.com/question/10201/project-name-bug"> Q&A.

Part of this checking should be in Developer. Basically the app id must be
[a-z][a-zA-Z0-9]*(.[a-z][a-zA-Z0-9])

AppTitle should be converted to conform to at project creation.
[A-Z][a-zA-Z0-9_]*

Comments

  1. Marshall Culpepper 2011-04-15

    (from [6d5df8e2877cb3b8b222cb09069f4204c5e8ee42]) added a shorter timeout / fatal error when we can't find any emulators/devices at all.new script for discovering currently running emulators/devices from developer, factored error/info/trace/debug/warn statements into functions that flush (so we don't see them too late) [#696] http://github.com/appcelerator/titanium_mobile/commit/6d5df8e2877cb3b8b222cb09069f4204c5e8ee42"> http://github.com/appcelerator/titanium_mobile/commit/6d5df8e2877cb...

  2. Marshall Culpepper 2011-04-15

    accidentally marked the wrong bug:
    https://appcelerator.lighthouseapp.com/projects/32238/changesets/b9bfce3a14a62b8cebb0bbe53199e87e1b84e650"> https://appcelerator.lighthouseapp.com/projects/32238/changesets/b9...

  3. Don Thorp 2011-04-15

    Title didn't conform. Test without quotes.

    "123 A Bad Class name"

    Created the class 123ABadClassNameActivity.java

  4. Marshall Culpepper 2011-04-15

    (from [9f3b35094f7c238cc21a70c27a1e0fa9918e2bf1]) take into account project names that start with numbers by prepending a _ [#696 state:resolved] http://github.com/appcelerator/titanium_mobile/commit/9f3b35094f7c238cc21a70c27a1e0fa9918e2bf1"> http://github.com/appcelerator/titanium_mobile/commit/9f3b35094f7c2...

JSON Source