Titanium

[TIMOB-873] Android KS: TableView append row with header test: no header appears

GitHub Issuen/a
TypeBug
PriorityMedium
StatusClosed
ResolutionFixed
Resolution Date2011-04-17T01:54:31.000+0000
Affected Version/sn/a
Fix Version/sSprint-2011-09
ComponentsAndroid
Labelsandroid, defect, release-1.6.1, release-1.7.0, reported-1.5.1, rplist
ReporterBill Dawson
AssigneeDon Thorp
Created2011-04-15T02:38:13.000+0000
Updated2011-04-17T01:54:31.000+0000

Description

Comments

  1. Don Thorp 2011-04-15

    Triage.

  2. Bill Dawson 2011-04-15

    My eval of the problem (untested): TableViewProxy.appendRow doesn't call processData() (which is the method that checks for and deals with headers) unless there are no pre-existing sections in the tableview. If there are already sections,it just finds the bottom section and inserts the row at the end, without evaluating data dictionary containing "header".

    For someone who knows what's going on, this looks like it might not be too big of a fix.

  3. Bill Dawson 2011-04-15

    This must've been fixed long ago. Not able to reproduce. And appendRow does now lead to calling processData, probably for a while now.

  4. Bill Dawson 2011-04-15

    Oops, ignore me. This is reproducible.

  5. kevinwhinnery 2011-04-15

    request from two pro seats is to include this fix on the 1.5.x branch

  6. Bill Dawson 2011-04-15

    https://github.com/appcelerator/titanium_mobile/commit/802c5618d9d73abac60ff22d4f791070ddea730c"> https://github.com/appcelerator/titanium_mobile/commit/802c5618d9d7...

  7. Bill Dawson 2011-04-15

    (from [e4abdaefb4fba65d3c88e45abad9078cef998831]) Make sure appended rows that have headers will create a section [#873 state:fixed-in-qa] https://github.com/appcelerator/titanium_mobile/commit/e4abdaefb4fba65d3c88e45abad9078cef998831"> https://github.com/appcelerator/titanium_mobile/commit/e4abdaefb4fb...

  8. Bill Dawson 2011-04-15

    (from [8e21f8b90896dc7b2085ea8ae6eac4568ea874a5]) Drillbit test for appendRow with header [#873] https://github.com/appcelerator/titanium_mobile/commit/8e21f8b90896dc7b2085ea8ae6eac4568ea874a5"> https://github.com/appcelerator/titanium_mobile/commit/8e21f8b90896...

  9. Natalie Huynh 2011-04-15

    Tested with 03012011_master on
    Android G1 1.6
    Android NexusOne 2.2.2
    Android Emulator 2.1
    iPhone 4 4.2.1

  10. Bill Dawson 2011-04-15

    (from [802c5618d9d73abac60ff22d4f791070ddea730c]) Make sure appended rows that have headers will create a section [#873 state:fixed-in-qa] https://github.com/appcelerator/titanium_mobile/commit/802c5618d9d73abac60ff22d4f791070ddea730c"> https://github.com/appcelerator/titanium_mobile/commit/802c5618d9d7...

  11. Bill Dawson 2011-04-15

    agent set back to fixed-in-qa. putting it back to resolved

JSON Source