{ "id": "173042", "key": "MOD-2497", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10034", "key": "MOD", "name": "Appcelerator Modules", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [], "resolution": null, "resolutiondate": null, "created": "2019-02-22T16:00:22.000+0000", "priority": { "name": "None", "id": "6" }, "labels": [], "versions": [], "issuelinks": [ { "id": "58391", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "inwardIssue": { "id": "173018", "key": "MOD-2495", "fields": { "summary": "AdMob: Migrate iOS to Swift and add parity with Android", "status": { "description": "The issue is open and ready for the assignee to start work on it.", "name": "Open", "id": "1", "statusCategory": { "id": 2, "key": "new", "colorName": "blue-gray", "name": "To Do" } }, "priority": { "name": "Medium", "id": "3" }, "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false } } } }, { "id": "58382", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "inwardIssue": { "id": "175031", "key": "MOD-2630", "fields": { "summary": "AdMob: Android & iOS parity (addressing Interstitial ad and BannerView)", "status": { "description": "Submitted for code review", "name": "In Review", "id": "10003", "statusCategory": { "id": 4, "key": "indeterminate", "colorName": "yellow", "name": "In Progress" } }, "priority": { "name": "None", "id": "6" }, "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false } } } } ], "assignee": { "name": "ybanev", "key": "ybanev", "displayName": "Yordan Banev", "active": true, "timeZone": "Europe/Athens" }, "updated": "2020-06-02T07:11:47.000+0000", "status": { "description": "Submitted for code review", "name": "In Review", "id": "10003", "statusCategory": { "id": 4, "key": "indeterminate", "colorName": "yellow", "name": "In Progress" } }, "components": [ { "id": "14509", "name": "Admob" } ], "description": "The iOS Swift rewrite in MOD-2495 already addresses a few parity issues between Android and iOS. This ticket is for changes required in the Android version of the module.\r\n\r\nParity issues that need to be addressed:\r\n\r\nFor the module proxy:\r\n* Add {{AD_SIZE_*}} constants\r\n* New method {{initialize}} to initialize the Google Ads SDK\r\n* Add {{debugIdentifiers}} property (see https://developers.google.com/admob/android/test-ads#enable_test_devices). This should replace {{requestTestAd}} from the banner view proxy.\r\n* Deprecate {{createView}} and replace with {{createBannerView}}\r\n* Remove Facebook audience framework. Not sure if this is possible on Android. We currently ship this by default for Facebook mediation. However i would like to remove it and users have to manually add it the their Project if they want to use it.. Should be easily done by just dropping it into a project's platform folder. There is no code setup necessary.\r\n* I would like to replace set/get tagForUnderAgeOfConsent with property {{isTaggedForUnderAgeOfConsent}}. In Swift this can be done with computed properties. Is this possible on Android?\r\n \r\nBanner view proxy:\r\n* Deprecate {{loadAd}} and {{requestAd}} and replace with {{load}}\r\n* Deprecate {{requestTestAd}}\r\n* Deprecate additional properties like {{prop_color_bg}} etc. Ad request customization should now be done via {{load}}\r\n* Add support for {{adSize}} option to specify the banner size. This is currently hardcoded to {{AdSize.Banner}}.\r\n* Remove deprecated properties {{testing}} and {{publisherId}} (Not sure for how long those are deprecated so maybe this needs to be done later)\r\n \r\nInterstitial Ad:\r\n* Add options for request customization to {{load}}\r\n* On iOS the proxy can be reused and a new interstitial ad is created each time \"load\" is called. Can we do the same on Android?\r\n \r\nGeneral:\r\n* Deprecate the event name constants and just use strings. I don't think we can actually deprecate them in the code so we just need to add a note in the docs. New event names for banner and insterstials would be:\r\n** {{ad_received}} => {{load}}\r\n** {{ad_not_received}} => {{fail}}\r\n** {{ad_closed}} => {{close}}\r\n** {{ad_opened}} => {{open}}\r\n** {{ad_left_application}} => {{leftapp}}", "attachment": [], "flagged": false, "summary": "AdMob: Parity between Android and iOS", "creator": { "name": "jvennemann", "key": "jvennemann", "displayName": "Jan Vennemann", "active": true, "timeZone": "Europe/Berlin" }, "subtasks": [], "reporter": { "name": "jvennemann", "key": "jvennemann", "displayName": "Jan Vennemann", "active": true, "timeZone": "Europe/Berlin" }, "environment": null, "comment": { "comments": [ { "id": "447988", "author": { "name": "ybanev", "key": "ybanev", "displayName": "Yordan Banev", "active": true, "timeZone": "Europe/Athens" }, "body": "PR: https://github.com/appcelerator-modules/ti.admob/pull/88", "updateAuthor": { "name": "ybanev", "key": "ybanev", "displayName": "Yordan Banev", "active": true, "timeZone": "Europe/Athens" }, "created": "2019-04-26T18:24:21.000+0000", "updated": "2019-04-26T18:24:21.000+0000" } ], "maxResults": 1, "total": 1, "startAt": 0 } } }