{ "id": "174117", "key": "MOD-2537", "fields": { "issuetype": { "id": "2", "description": "A new feature of the product, which has yet to be developed.", "name": "New Feature", "subtask": false }, "project": { "id": "10034", "key": "MOD", "name": "Appcelerator Modules", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "20887", "name": "Release 8.2.0", "archived": false, "released": false } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2019-09-12T19:07:11.000+0000", "created": "2019-09-11T14:57:27.000+0000", "priority": { "name": "None", "id": "6" }, "labels": [], "versions": [], "issuelinks": [ { "id": "57837", "type": { "id": "10001", "name": "Cloners", "inward": "is cloned into", "outward": "is cloned from" }, "outwardIssue": { "id": "174046", "key": "MOD-2534", "fields": { "summary": "TiAPI: Update Facebook SDK's to latest (iOS 5.4.1, Android 5.4.0) to support iOS 13", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "None", "id": "6" }, "issuetype": { "id": "2", "description": "A new feature of the product, which has yet to be developed.", "name": "New Feature", "subtask": false } } } }, { "id": "57840", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "inwardIssue": { "id": "173034", "key": "TIMOB-26842", "fields": { "summary": "CLI: Deprecate allowing no version to be set on a module in the tiapp", "status": { "description": "The issue is open and ready for the assignee to start work on it.", "name": "Open", "id": "1", "statusCategory": { "id": 2, "key": "new", "colorName": "blue-gray", "name": "To Do" } }, "priority": { "name": "None", "id": "6" }, "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false } } } } ], "assignee": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "updated": "2019-09-17T18:02:06.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "14521", "name": "Facebook" } ], "description": "The Facebook libs once again need to be updated, especially on iOS to support iOS 13+.\r\n\r\nhttps://github.com/appcelerator-modules/ti.facebook/pull/103\r\n\r\nEdit - This ticket include a part of fix from above PR to fix iOS 13 crash. For other changes we will go with MOD-2534", "attachment": [ { "id": "66938", "filename": "image1.png", "author": { "name": "kmahalingam", "key": "kmahalingam", "displayName": "Keerthi Mahalingam", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2019-09-13T03:46:43.000+0000", "size": 273996, "mimeType": "image/png" } ], "flagged": false, "summary": "ti.facebook: crash on iOS 13", "creator": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "subtasks": [], "reporter": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "environment": null, "closedSprints": [ { "id": 1163, "state": "closed", "name": "2019 Sprint 19", "startDate": "2019-09-09T20:43:13.091Z", "endDate": "2019-09-22T20:43:00.000Z", "completeDate": "2019-09-23T15:37:35.874Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "451291", "author": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "body": "https://github.com/appcelerator-modules/ti.facebook/pull/108", "updateAuthor": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "created": "2019-09-11T15:00:30.000+0000", "updated": "2019-09-11T15:00:30.000+0000" }, { "id": "451294", "author": { "name": "amukherjee", "key": "amukherjee", "displayName": "Abir Mukherjee", "active": true, "timeZone": "America/Los_Angeles" }, "body": "[~lchoudhary] can someone in QE please validate before closing?", "updateAuthor": { "name": "amukherjee", "key": "amukherjee", "displayName": "Abir Mukherjee", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-09-11T16:15:09.000+0000", "updated": "2019-09-11T16:15:09.000+0000" }, { "id": "451318", "author": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Facebook has [login issue|https://github.com/facebook/facebook-objc-sdk/issues/1013] with iOS 13 and they fixed it in their SDK 5.4.1.\r\nIf we use their latest SDK, they have removed FBSDKMessengerShareKit.framework (in 5.0.0). In our module we give functionality to create facebook [messenger button|https://docs.appcelerator.com/platform/latest/#!/api/Modules.Facebook.MessengerButton] which uses FBSDKMessengerShareKit.framework. So if we use latest Facebook SDK, we have to make breaking change.\r\n\r\nSolution is - Include FBSDKMessengerShareKit.framework from older Facebook SDK in our facebook module and give the facebook [messenger button|https://docs.appcelerator.com/platform/latest/#!/api/Modules.Facebook.MessengerButton] to developer. Remove it in major SDK release, 9.0.0.\r\n\r\nSo I have created [PR-109|https://github.com/appcelerator-modules/ti.facebook/pull/109] base to https://github.com/appcelerator-modules/ti.facebook/pull/103, included FBSDKMessengerShareKit.framework and restored facebook messenger button functionality.\r\n\r\ncc [~cwilliams]", "updateAuthor": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-09-12T01:23:18.000+0000", "updated": "2019-09-12T01:23:18.000+0000" }, { "id": "451337", "author": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "body": "[~lchoudhary] Here's the PR that Vijay has put together with the updated Facebook libraries and the messenger button retained: https://github.com/appcelerator-modules/ti.facebook/pull/109\r\n\r\nThere are (very) basic unit tests around the messenger button that run but they basically just rove the API exists, not functionality. I think the concern here is to ensure that the messenger stuff still works with Vijay's changes and the new FB libraries. if not, then we'd probably be forced to take the breaking changes introduced by Han's original PR for MOD-2534", "updateAuthor": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "created": "2019-09-12T19:09:34.000+0000", "updated": "2019-09-12T19:09:34.000+0000" }, { "id": "451341", "author": { "name": "kmahalingam", "key": "kmahalingam", "displayName": "Keerthi Mahalingam", "active": false, "timeZone": "America/Los_Angeles" }, "body": "[~cwilliams] tested the example app in facebook module with the fix. facebook messenger did not work.on clicking messenger button throws “error :undefined and code :undefined” in device iOS 13 as well as lesser than that. Not getting any error in console. Also tried with older facebook module 6.0.0.same thing happened !image1.png|thumbnail! ", "updateAuthor": { "name": "kmahalingam", "key": "kmahalingam", "displayName": "Keerthi Mahalingam", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2019-09-13T03:47:23.000+0000", "updated": "2019-09-13T03:48:23.000+0000" }, { "id": "451373", "author": { "name": "kmahalingam", "key": "kmahalingam", "displayName": "Keerthi Mahalingam", "active": false, "timeZone": "America/Los_Angeles" }, "body": "Tested with the PR https://github.com/appcelerator-modules/ti.facebook/pull/103. login with facebook works fine on iOS 13", "updateAuthor": { "name": "kmahalingam", "key": "kmahalingam", "displayName": "Keerthi Mahalingam", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2019-09-13T21:07:54.000+0000", "updated": "2019-09-13T21:07:54.000+0000" }, { "id": "451448", "author": { "name": "kmahalingam", "key": "kmahalingam", "displayName": "Keerthi Mahalingam", "active": false, "timeZone": "America/Los_Angeles" }, "body": "Verified the fix on sdk 8.2.0.v20190917100859. Facebook module works. able to login with facebook successfully .\r\n\r\n", "updateAuthor": { "name": "kmahalingam", "key": "kmahalingam", "displayName": "Keerthi Mahalingam", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2019-09-17T18:02:00.000+0000", "updated": "2019-09-17T18:02:00.000+0000" } ], "maxResults": 9, "total": 9, "startAt": 0 } } }