Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-11580] Android: VideoPlayer.playbackstate.playbackstate should be playbackState

GitHub Issuen/a
TypeBug
PriorityHigh
StatusClosed
ResolutionFixed
Resolution Date2012-11-14T19:28:06.000+0000
Affected Version/sRelease 3.0.0
Fix Version/sRelease 3.0.0, Release 3.1.0, 2012 Sprint 23 API, 2012 Sprint 23
ComponentsAndroid
Labelsapi, parity, regression, triage
ReporterArthur Evans
AssigneePing Wang
Created2012-10-26T18:30:51.000+0000
Updated2012-12-04T00:24:15.000+0000

Description

The playbackstate event has a property named playbackState. However, on Android, when the event was renamed from playbackState to playbackstate, the event *property* was renamed as well. The property name should stay the same, as it is documented, as it worked on Android in 2.1.3, and as it works in iOS in 3.0.

Comments

  1. Arthur Evans 2012-10-26

    This is a regression as well, since the property was renamed in both the legacy playbackState and the new playbackstate events.
  2. Ping Wang 2012-10-29

    PR https://github.com/appcelerator/titanium_mobile/pull/3346 For FR, please run KS->Phone->Play Movie->Local and check the log in the console. Should see something like:
       I/TiAPI   ( 3788):  Event PlaybackState Fired: 1
       
    Without the fix, the log is:
       I/TiAPI   ( 4401):  Event PlaybackState Fired: undefined
       
  3. Ping Wang 2012-10-29

    3_0_X PR: https://github.com/appcelerator/titanium_mobile/pull/3347
  4. Natalie Huynh 2012-12-04

    Tested with 3.0.0.v201211300200208 with Galaxy s3 4.0.4 and iphone 4 5.1.1

JSON Source