[TIMOB-12002] CLI: Remove iphone and ipad platform options
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Medium |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2013-01-16T09:24:02.000+0000 |
| Affected Version/s | Release 3.0.0 |
| Fix Version/s | Release 3.0.0, Release 3.1.0, 2012 Sprint 25, 2012 Sprint 25 JS |
| Components | CLI |
| Labels | n/a |
| Reporter | Chris Barber |
| Assignee | Chris Barber |
| Created | 2012-12-08T00:39:50.000+0000 |
| Updated | 2013-01-17T03:46:37.000+0000 |
Description
Since "iphone", "ipad", and "ios" all do the same thing, it's best to remove "iphone" and "ipad" to remove confusion. Use the device targets in the tiapp.xml or --device-family option to specify "iphone", "ipad", or "universal".
Master pull request: https://github.com/appcelerator/titanium_mobile/pull/3563 3.0.x pull request: https://github.com/appcelerator/titanium_mobile/pull/3564
Reopening because I found two more spots that I missed.
Master pull request: https://github.com/appcelerator/titanium_mobile/pull/3573 3.0.x pull request: https://github.com/appcelerator/titanium_mobile/pull/3574
Running "Titanium build -p iphone -F ipad" builds the project. It still accepts platform argument as iphone,ipad for platform options and successfully build the project. As the iphone,ipad options are not removed from platform argument. If we run "Titanium build" it prompts as " Target platform [android,ios,mobileweb]:" If User provide iphone,ipad option to it then also it builds successfully. Verified on : SDK version: 3.1.0.v20130111163212, 3.0.0.GA CLI version : 3.0.22 OS : MAC OSX 10.7.5 XCode : 4.5.1
This is expected behavior. Nowhere does the CLI advertise that "iphone" or "ipad" are valid build targets, but for a period of time we did allow them. This ticket exists because it doesn't make sense to have "iphone", "ipad", and "ios" targets that are all identical. Too confusing. The reason we still allow "iphone" and "ipad" is because there are versions of Titanium Studio that may still be in use that pass in "iphone" or "ipad" instead of "ios". Someday we'll rip out support for "iphone" and "ipad", but it doesn't hurt anything to leave it in.
Working as expected Verified on : SDK version: 3.1.0.v20130111163212, 3.0.0.GA CLI version : 3.0.22 OS : MAC OSX 10.7.5 XCode : 4.5.1