[TIMOB-12423] CLI: Switch authentication library to use request module
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Critical |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2013-01-28T20:32:19.000+0000 |
| Affected Version/s | Release 3.0.0 |
| Fix Version/s | Release 3.0.2, Release 3.1.0, 2013 Sprint 02 JS, 2013 Sprint 02 |
| Components | CLI |
| Labels | n/a |
| Reporter | Chris Barber |
| Assignee | Chris Barber |
| Created | 2013-01-25T11:17:35.000+0000 |
| Updated | 2013-02-19T17:48:45.000+0000 |
Description
The auth library in node-appc uses node's built-in http client which does not support proxy servers. We need to rip out node's http request library and use the "request" module like we do everywhere else.
Users in the Q&A are having problems logging in: http://developer.appcelerator.com/question/146837/unable-to-login-with-titanium-cli-version-3022.
Pull request: https://github.com/appcelerator/node-appc/pull/28
Have coordinated with Kailun, will test on proxy setup.
@Eric, I talked to Kailun, but there are no plans to implement a proxy, specifically one with authentication. We used http://www.hidemyass.com/proxy-list/ to test the proxy stuff.
Closing based on Federico and Lokesh's work.