[TIMOB-12450] Android: TableViewRow with className crash when adding a view and scrolling

Problem description

Adding a view to a row on the fly, if the row has className enabled, results in a crash as soon as the table scrolls.

Comments

Lets say you want to implement a menu on row. The "lighter" way is to add the menu when necessary and remove it as soon as possible. If you are using the 'className' property of the row then a crash occurs while scrolling (reuse of a cell). If you remove the className property in the code below, then it works. In more complex code of mine I can see that the reuse works perfectly without className. So using className should work as well (even better).

Steps to reproduce

Use the following code; click on a row, then scroll down to see the crash.

var win = Titanium.UI.createWindow();
win.backgroundColor = '#ccc';

var tableview = Ti.UI.createTableView();
win.add(tableview);

var rowData = [];
for (var i = 0; i < 100; i++) {
	var row = Ti.UI.createTableViewRow({
		title : 'row ' + i,
		height : 90,
		className : 'myrow'
	});
	row.view = Ti.UI.createView({
		left : 0,
		right : 0,
		top : 0,
		bottom : 0,
		backgroundColor : 'blue'
	})
	row.add(row.view);
	rowData.push(row);
};
tableview.data = rowData;

tableview.addEventListener('click', function(e) {
	if (e.row) {
		Ti.API.info('testing ')
		if (!e.row.menu || e.row.menu === null) {
			e.row.menu = Ti.UI.createView({
				width : 50,
				right : 0,
				backgroundColor : 'black'
			})
			e.row.view.add(e.row.menu);
		} else {
			e.row.view.remove(e.row.menu);
			e.row.menu = null;
		}
	}
})

win.open();

The error reported: E/TiApplication( 4545): java.lang.ArrayIndexOutOfBoundsException: length=0; index=0 E/TiApplication( 4545): at ti.modules.titanium.ui.widget.tableview.TiTableViewRowProxyItem.applyChildProperties(TiTableViewRowProxyItem.java:176)