[TIMOB-12605] Android: No error comes, when guid is not present in tiapp.xml
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | High |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2013-10-19T01:22:15.000+0000 |
| Affected Version/s | Release 3.0.0, Release 3.0.2, Release 3.1.0 |
| Fix Version/s | 2013 Sprint 21, 2013 Sprint 21 Core, Release 3.2.0 |
| Components | Android, Tooling |
| Labels | androidbuild, ay-verified, cb-verified, cli, qe-sdk3.0.2, qe-testadded |
| Reporter | Paras Mishra |
| Assignee | Chris Barber |
| Created | 2013-02-06T12:31:26.000+0000 |
| Updated | 2014-06-19T12:43:09.000+0000 |
Description
Android: No error comes, when guid is not present in tiapp.xml
Its not a regression.
Tested on google nexus, android version: 4.1
Steps to reproduce:
1. Comment out guid in tiapp.xml in default titanium project.
2. Reach out to the project directory in terminal.
3. Run titanium build -T device
Actual:
No error comes and app installs on device.
Expected:
ERROR] : tiapp.xml is missing the element
The guid must be in the format XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX and consist of letters and numbers.
Issue reproduces with Titanium Studio, build: 3.0.1.201212181159 Titanium SDK version: 3.1.0 (03/11/13 15:43 0c88429) Titanium SDK version: 3.0.2 (02/07/13 16:46 a4def81) Device: Samsung galaxy s duos Android version: 4.0.4 jithinpv
Tested this with 3.1.1.GA and it properly errors out when there isn't a guid or the guid is bad. I looked at the 3.1.0.GA code and it looks fine too.
PR: https://github.com/appcelerator/titanium_mobile/pull/4781
+Verified fixed on:+ Mac OSX 10.9 Mavericks Titanium Studio, build: 3.2.0.201311060354 Titanium SDK, build: 3.2.0.v20131105162443 CLI: 3.2.0 Alloy: 1.3.0 +*Produced the error message:*+ If you need a new guid, below are 5 freshly generated new ones that you can choose from: {color:red} [ERROR] : tiapp.xml is missing the