[TIMOB-13316] Android: verticalAlign: 'middle' doesn't conform to TEXT_VERTICAL_ALIGNMENT_CENTER
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Low |
| Status | Closed |
| Resolution | Won't Fix |
| Resolution Date | 2013-05-07T14:11:42.000+0000 |
| Affected Version/s | Release 3.0.2 |
| Fix Version/s | n/a |
| Components | Android |
| Labels | exalture |
| Reporter | Martin Guillon |
| Assignee | Sunila |
| Created | 2012-09-04T08:29:15.000+0000 |
| Updated | 2017-03-22T21:11:25.000+0000 |
Description
It should be 'center' instead of 'middle' to conform with TEXT_VERTICAL_ALIGNMENT_CENTER
This is what was done on iPhone:
https://github.com/appcelerator/titanium_mobile/pull/2645
I'm quite sure this is no longer an issue for 3.0, but let me know if it is with references to our docs and I'll reopen. Cheers.
It is still an issue. Simply look at the code https://github.com/appcelerator/titanium_mobile/blob/master/android/titanium/src/java/org/appcelerator/titanium/util/TiUIHelper.java#L462
Daniel: About my pull request. It s not been followed by Appcelerator so i let it as it was. It s completely out of sync!! For example now i have a completely new Label with html, ellipsizis, shadows .... And lot more android/iphone properties for the buttons. If appcelerator still wants my new widgets, please let me know. The pull request might be big!
Should be using UI Module constants
Closing ticket as "Won't Fix".