Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-13359] Android: Support error object of an event payload other than string

GitHub Issuen/a
TypeBug
PriorityCritical
StatusClosed
ResolutionFixed
Resolution Date2013-04-05T23:48:04.000+0000
Affected Version/sRelease 3.1.0
Fix Version/sRelease 3.1.0, 2013 Sprint 07 Core, 2013 Sprint 07, Release 3.2.0
ComponentsAndroid
Labelsmodule_android, qe-testadded
ReporterMatt Langston
AssigneeMatt Langston
Created2013-04-03T23:07:37.000+0000
Updated2014-02-11T11:03:06.000+0000

Description

Changes introduced in TIMOB-12651 enforced that error objects of an event payload must be of type String, but this broke backward compatibility discovered while optimizing Lanica's "Gardens of Time" app. We should still allow error object to be other than String for backwards compatibility, but also issue e deprecation warning. See here for the change introduced in 3.1.0: https://github.com/BlainHamon/titanium_mobile/commit/d2102b5d9020a11b26cd51a92c23029b68082240

Attachments

FileDateSize
timob_13359_app.zip2013-04-05T21:37:28.000+0000825173
timob13359module.zip2013-04-05T21:37:28.000+00001760801

Comments

  1. Matt Langston 2013-04-04

    Pull request for master: https://github.com/appcelerator/titanium_mobile/pull/4071
  2. Matt Langston 2013-04-04

    Pull request for backport to 3_1_X: https://github.com/appcelerator/titanium_mobile/pull/4085
  3. Allen Yeung 2013-04-05

    https://github.com/appcelerator/titanium_mobile/pull/4091 Backport: https://github.com/appcelerator/titanium_mobile/pull/4092
  4. Eric Merriman 2013-04-11

    How can we test this?
  5. Matt Langston 2013-04-12

    Hi Eric, Run the attached app with the attached module against any SDK. If the bug is fixed in the SDK you build against then the app will print 
       MDL: TIMOB-13359 is fixed
    in the log window. If the bug is not fixed in the SDK you build against then the app will print 
       MDL: TIMOB-13359 is not fixed
    in the log window. -Matt
  6. Shyam Bhadauria 2013-05-09

    Run the attached app with the attached module against any SDK. It printed in the console: MDL: TIMOB-13359 is fixed Used environment for verification SDK - 3.1.0.GA , 3.1.1.v20130508001914 Appcelerator Studio, build: 3.1.1.201305072102 Device : Samsung GALAXY Note Android 2.3.6

JSON Source