[TIMOB-13862] CLI: tiapp.xml sdk-version not honored if selected sdk has same base digits

GitHub Issue	n/a
Type	Bug
Priority	High
Status	Closed
Resolution	Fixed
Resolution Date	2013-08-28T23:17:26.000+0000
Affected Version/s	n/a
Fix Version/s	2013 Sprint 18 Core, 2013 Sprint 18, Release 3.2.0
Components	CLI
Labels	qe-closed-3.2.0
Reporter	Chris Barber
Assignee	Chris Barber
Created	2013-05-15T05:08:55.000+0000
Updated	2013-11-26T23:24:03.000+0000

Description

If the tiapp.xml is set to 3.1.1.v20130514180723, but the CLI is set to 3.1.1.v20130513120107, since both start with 3.1.1, the CLI thinks they are the same version which is wrong.

Comments

Chris Barber 2013-08-27

Pull request: https://github.com/appcelerator/titanium_mobile/pull/4612
Chris Barber 2013-08-27

To test: 1) Install 2 different CI builds (I tested with 3.1.1, but the 3.1.3 builds should work fine... you just need to be sure the X.Y.Z are the same and the timestamps are different) 2) Select one of the CI builds as the selected sdk 3) Assign the other CI build as your app's in the tiapp.xml 4) Build and notice it should properly fork the correct CI build (instead of using the selected one)

Olga Romero 2013-11-26

Tested and verified the fix with: CLI 3.2.0-alpha3 tiapp.xml - 3.1.3.GA selected SDK - 3.2.0.v20131126111643

   [INFO]  tiapp.xml <sdk-version> set to 3.1.3.GA, but current Titanium SDK set to 3.2.0.v20131126111643
   [INFO]  Forking correct SDK command: "/usr/local/bin/node" "/usr/local/bin/ti" "build" "--sdk" "3.1.3.GA" "--config-fi

Olga Romero 2013-11-26

   [INFO]  tiapp.xml <sdk-version> set to 3.2.0.v20131029150357, but current Titanium SDK set to 3.2.0.v20131126111643
   [INFO]  Forking correct SDK command: "/usr/local/bin/node" "/usr/local/bin/ti" "build" "--sdk" "3.2.0.v20131029150357" "--config-file

JSON Source