[TIMOB-13987] Code Processor: Alloy hook validation needs to happen after logging redirection, not before
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Critical |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2013-05-24T22:41:04.000+0000 |
| Affected Version/s | Release 3.1.1 |
| Fix Version/s | 2013 Sprint 11 JS, 2013 Sprint 11, Release 3.1.1, Release 3.2.0 |
| Components | Code Processor |
| Labels | n/a |
| Reporter | Bryan Hughes |
| Assignee | Bryan Hughes |
| Created | 2013-05-24T22:18:16.000+0000 |
| Updated | 2013-06-17T17:47:32.000+0000 |
Description
Right now, the alloy hook is validated before the logger is redirected when using a configuration file. This means that when a configuration file is used on an alloy project with an out of date hook and the output type is stream or JSON, the warning is printed which makes the output unparseable.
PR: https://github.com/appcelerator/titanium-code-processor/pull/202 1_0_X PR: https://github.com/appcelerator/titanium-code-processor/pull/203
Is there a way we can test this?
To test/verify:
Get an alloy project created with 1.1.2 or older (it must have the old hook in plugins/)
Run the code processor from the command line against the project: "ti analyze -F -o json"
Without the fix, you will see some output before the JSON is output, meaning that it isn't valid JSON
With the fix, you will only see JSON output
Verified as fixed. Environment: Titanium SDK 3.1.1.v20130615160957 Appcelerator Studio 3.1.1.201306131423 CLI 3.1.1-cr Code Processor 1.0.1-cr5 Alloy 1.1.3-cr Node 0.8.22 Closing.