[TIMOB-14014] Code Analyzer: 'Grade' value in Category Scores section is always N/A
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | High |
| Status | Closed |
| Resolution | Won't Fix |
| Resolution Date | 2016-08-24T20:01:09.000+0000 |
| Affected Version/s | Release 3.1.1 |
| Fix Version/s | 2013 Sprint 11 JS, 2013 Sprint 11, Release 3.1.1, Release 3.2.0 |
| Components | Code Processor |
| Labels | code-analyzer, qe-3.1.1, qe-closed-3.1.1, qe-testadded |
| Reporter | Federico Casali |
| Assignee | Eric Merriman |
| Created | 2013-05-29T00:40:24.000+0000 |
| Updated | 2017-03-20T20:29:21.000+0000 |
Description
Problem description
When using the Code Analyzer for Alloy projects, the Grade in the results is always N/ASteps to reproduce
1. Create a default new Alloy project (for example the default Two-Tab Project, as attached). 2. Run Code-Processor and check the results Result: in the Category Score section, the Grade values are always N/A. This applies to all the Alloy projects analyzed so far.Attachments
| File | Date | Size |
|---|---|---|
| Alloy_sampleTODOapp.zip | 2013-05-31T18:37:57.000+0000 | 94561 |
| alloy_twoTabbedDefault.zip | 2013-05-29T00:40:24.000+0000 | 7410027 |
| Screen Shot 2013-05-31 at 11.35.37 AM.png | 2013-05-31T18:37:57.000+0000 | 43220 |
Note: there is wording on the summary page that explains that not enough code was analyzed to provide a score, but this messaging is not shown on the project score page and should be.
[~bhughes] Can you fix the message ASAP?
[~ingo] or [~bhughes] I set up the plugin, ran
against an alloy 2 tabbed app and got the following output with regards to the score on both the summary and the project score section:Is this considered to be a pass for the functional testing? If so, I will merge it and resolve this ticket as code review passes.Code and functional review pass. Both PRs have been merged.
Sorry to get back to you so late, but yes that is expected. This fix was purely a messaging fix, not a functionality fix.
Message is displayed correctly and when there is enough code to be analyzed a Project Grade score is correctly given. However, 'Grade' values in the Category Scores section details are still displayed as N/A. See screenshot. Attached a sample Alloy project which is returning a Project Grade B but displaying the Category Scores table with all Grade values set to N/A as in the screenshot.
Also reproducible with a default Classic (non-Alloy) Tabbed Application. In this case the Grade is A - but in the 'Category Scores' table under 'Project Score' section, all the entries have 'Grade' value N/A instead of A.
PR: https://github.com/appcelerator/appcelerator-code-processor-plugins/pull/32 1_0_X PR: https://github.com/appcelerator/appcelerator-code-processor-plugins/pull/33
Code and functional review passes. Both PRs merged.
Verified as fixed. Environment: Appcelerator Studio 3.1.1.201306032350 Titanium SDK 3.1.1.v20130531163723 CLI 3.1.1-cr Alloy 1.1.3-cr Titanium-Code-Processor 1.1.3-cr Closing.
The issue is reproducible with the below environment with Alloy projects. Tested on: 1. Mac OSX Yosemite 10.10 2. Appcelerator Studio, build: 3.4.1.201410281743 3. Titanium SDK, build: 3.5.0.v20141217170926 4. Titanium CLI, build: 3.4.1 5. Alloy: 1.5.1 6. Xcode 6.1 7. iOS SDK 8.1 8. iPhone 5s with iOS 8.1 In the Category Score section, the Grade values are always N/A. This applies to all the Alloy projects analyzed so far.
Code processor is dead.
Closing ticket as Code processor is no longer supported.