[TIMOB-14195] Maps V2: Version and changelog should be incremented to show additions for new API
| GitHub Issue | n/a |
|---|
| Type | Bug |
|---|
| Priority | Critical |
|---|
| Status | Closed |
|---|
| Resolution | Fixed |
|---|
| Resolution Date | 2013-06-14T00:30:30.000+0000 |
|---|
| Affected Version/s | Release 3.1.1 |
|---|
| Fix Version/s | 2013 Sprint 12 API, 2013 Sprint 12, Release 3.1.1, Release 3.2.0 |
|---|
| Components | n/a |
|---|
| Labels | qe-3.1.1 |
|---|
| Reporter | Eric Merriman |
|---|
| Assignee | Hieu Pham |
|---|
| Created | 2013-06-12T23:49:01.000+0000 |
|---|
| Updated | 2013-06-14T21:13:48.000+0000 |
|---|
Description
Description:
We added an API for "isGooglePlayServicesAvailable", but the changelog and module version remain unchanged. To avoid confusion and a possible overwrite of an existing 1.2.0 module folder in the SDK install location, we should rev the version.
Steps to reproduce:
1) Install SDK 3.1.1.v20130611153550
2) Navigate to your module install location (generally ~/Library/application support/titanium/modules/android/ti.map/
3) Examine the sample code line #4
Result:
The version is 1.2.0 prior to the change, and 1.2.0 after. If line 4 contains the new API, then you have the latest version.
The change log does not reflect the changes to 1.2.0 (to include the new api)
Expected Result:
Version is installed side-by-side with 1.2.0, has a unique version, and the changelog describes new API addition.
Comments
JSON Source
https://github.com/appcelerator/titanium_modules/pull/121
master PR: https://github.com/appcelerator/titanium_mobile/pull/4389 3_1_X PR: https://github.com/appcelerator/titanium_mobile/pull/4392
Verified pull. Will verify public repo then close.
Verified version and changelog fix on github and in SDK.