[TIMOB-15424] Allow ScrollableView to set pageIndicatorColor and currentPageIndicatorColor

GitHub Issue	n/a
Type	New Feature
Priority	Low
Status	Closed
Resolution	Fixed
Resolution Date	2016-03-28T16:48:46.000+0000
Affected Version/s	Release 3.1.3
Fix Version/s	Release 5.4.0
Components	iOS
Labels	qe-5.4.0, scrollableView
Reporter	Joseph Sachs
Assignee	Hans Knöchel
Created	2013-10-06T21:44:44.000+0000
Updated	2016-06-09T17:45:07.000+0000

Description

Every Ti SDK update, I have to manually edit the files to set my own custom colors for pageIndicatorColor and currentPageIndicatorColor: - TiUIScrollableView.h - TiUIScrollableView.m - TiUIScrollableViewProxy.h - TiUIScrollableViewProxy.m Following this GitHub repo: https://github.com/boardmain/TitaniumMods/tree/master/3.0.2.GA This works well with Ti SDK 3.1.3, though I have to manually update them with each update of Ti SDK (adding *just* the pageIndicatorColor & currentPageIndicatorColor features)

Comments

Daniel Ethier 2014-07-17

This is a fairly simple change. I would also like to see this added to Titanium. Thanks.
Ed 2014-08-17

+1 on this. Having hardcoded white indicators over light backgrounds renders them invisible. The pageIndicatorTintColor and currentPageIndicatorTintColor properties have been available since iOS 6, and [Samuel has provided a patch](http://developer.appcelerator.com/question/148904/paging-control-color-sdk-update-if-u-need-it) for via on [github](https://github.com/boardmain/TitaniumMods/tree/master/3.0.2.GA). It would be great if this finally made it into the Ti SDK. Thanks!
Brad White 2014-12-17

+1 on having this included - the work is already done.
BABLY DAS 2015-02-13

Please implement this change. Its an overhead to use external modules to get the color of the dots properly for Scrollable View. Thanks.
Ingo Muschenetz 2015-02-16

Hi All, we cannot accept the patch unless it is submitted against the titanium_mobile repository. Is someone able to do that?
Manuel Lehner 2015-04-15

[~ingo] Here's a PR: https://github.com/appcelerator/titanium_mobile/pull/6781 I'm using Samueles patch since 3.2.0, it works just fine! Would love to see this in the official SDK (finally).

Hans Knöchel 2016-03-27

PR: https://github.com/appcelerator/titanium_mobile/pull/7888 Demo:

   var win = Ti.UI.createWindow();
   var scrollable = Ti.UI.createScrollableView({
       showPagingControl: true,
       pageIndicatorColor: "red",
       currentPageIndicatorColor: 'green',
       pagingControlColor: "yellow",
   });
   
   scrollable.addView(Ti.UI.createView({backgroundColor: "darkgray"}));
   scrollable.addView(Ti.UI.createView({backgroundColor: "red"}));
   scrollable.addView(Ti.UI.createView({backgroundColor: "yellow"}));
   
   win.add(scrollable);
   win.open();

Thanks again [~manuellehner] for the initial PR and the great communication around the ticket!

Bert Grantges 2016-05-06

Has this been merged? is it going to make the upcoming release?
Harry Bryant 2016-06-09

Verified as fixed, ScrollableView is now able to set pageIndicatorColor , currenPageIndicatorColor , and pagingControlColor Tested On: iPhone 6S (9.3.2) Device Mac OSX El Capitan 10.11.5 Ti SDK: 5.4.0.v20160608165242 Appc Studio: 4.6.0.201605180604 Appc NPM: 4.2.7.-2 App CLI: 5.4.0-11 Xcode 7.3 Node v4.2.6 *Closing ticket.*

JSON Source