Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-15662] CLI: JS Minify - skip-js-minify flag does not minify JS

GitHub Issuen/a
TypeBug
PriorityHigh
StatusClosed
ResolutionFixed
Resolution Date2013-11-07T01:36:02.000+0000
Affected Version/sn/a
Fix Version/s2013 Sprint 23, 2013 Sprint 23 Core, Release 3.2.0
ComponentsCLI
Labelsqe-3.2.0
ReporterWilson Luu
AssigneeChris Barber
Created2013-11-05T01:32:50.000+0000
Updated2014-06-19T12:44:09.000+0000

Description

*Details:* skip-js-minify flag does not minify JS. *Steps to reproduce:* 1. Clone KS from https://github.com/appcelerator-developer-relations/KitchenSink 2. Install KS to device using the following CLI command: ti build --skip-js-minify -p ios -P 6C8B12C4-7EC4-43DE-8CEB-B9DC4C3A4F88 -T device -I 7.0.3 -V "QE Department (C64864TF2L)" -C "Europa" *Actual:* JS will not be minified (see minify.txt) *Expected:* JS should be minified when using the skip-js-minify flag

Attachments

FileDateSize
minify.txt2013-11-05T01:32:50.000+00001724

Comments

  1. Chris Barber 2013-11-06

    Pull request: https://github.com/appcelerator/titanium_mobile/pull/4919
  2. Wilson Luu 2013-11-07

    Closing ticket as fixed. Verified --skip-js-minify flag is honored while using this default Titanium app code to verify:
       label1.addEventListener('click', function(e){
            // runtime error here
           acdert('clicked');
       });
       
    Tested on: Titanium Studio, build: 3.2.0.201311070117 SDK build: 3.2.0.v20131106174044 Ti CLI: 3.2.0 master (4c816f21d7d9360659d77e9a6a994992ef880b72) Xcode: 5.0.1 Device: iphone 5 (6.1.3), iphone 5s (7.0.2)

JSON Source