[TIMOB-15770] Android: When Facebook autorize, App crashed on Android 4.4 kitkat.
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | High |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2013-11-27T18:50:51.000+0000 |
| Affected Version/s | Release 3.1.3 |
| Fix Version/s | 2013 Sprint 24, 2013 Sprint 24 API, Release 3.2.0, Release 3.3.0 |
| Components | Android |
| Labels | SupportTeam, module_api, qe-testadded |
| Reporter | Jong Eun Lee |
| Assignee | Ping Wang |
| Created | 2013-11-14T07:48:26.000+0000 |
| Updated | 2014-07-31T06:39:51.000+0000 |
Description
When Facebook autorize, App crashed on Android 4.4 kitkat.
On Nexus 4 with android 4.3, it works properly.
Pleas put your facebook app id before below test code.
var fb = require('facebook');
fb.appid = "YOUR_FACEBOOK_APP_ID";
fb.authorize();
Hello! Can you please provide a crashlog? Use DDMS or similar. Best, Mauro
Is this enough? Best, Jong.
Tested the code below on build 3.2.0.v20131119142443
var fb = require('facebook'); fb.appid = 'YOUR FACEBOOK APPID'; fb.permissions = ['publish_stream', 'read_stream']; // Permissions your app needs fb.forceDialogAuth = true; var win = Ti.UI.createWindow({ backgroundColor:'white' }); var but = Ti.UI.createButton({ title:'authorize', top:50 }); but.addEventListener('click',function(e){ fb.addEventListener('login', function(e) { if (e.success) { alert('Logged In'); } else if (e.error) { alert(e.error); } else if (e.cancelled) { alert("Canceled"); } }); fb.authorize(); }); var but1 = Ti.UI.createButton({ title:'Logout', top:120 }); but1.addEventListener('click',function(e){ fb.addEventListener('logout', function(e) { alert('Logged out'); }); fb.logout(); }); win.add(but); win.add(but1); win.open();On a nexus 4 running android 4.3, I get following errors:
Tested with the latest master. 1. On Nexus7 (4.3): i) Ran the test app and got the same runtime error with last comment. ii) KS->MASHUPS->Facebook->Login/Logout works fine. 2. On 4.4 devices: i) If
is set in tiapp.xml, the test app works fine. Otherwise, it will not pop up the login web view as described in the above comment. ii) Ifis set in tiapp.xml, the test app crashes with logiii) KS->MASHUPS->Facebook->Login/Logout works fine.PR: https://github.com/appcelerator/titanium_modules/pull/148 For FR, please run the test case on 4.4 and 4.3 devices. Should not see any error or crash when login/logout.
PR approved and merged into _titanium_modules_ master
SDK PR: https://github.com/appcelerator/titanium_mobile/pull/5042 3_2_X backport: https://github.com/appcelerator/titanium_mobile/pull/5043
Merged
Verified the fix. We do not see any app crash when fb.authorize() is used & we successfully get the facebook login propmt. Closing. Environment: Appcel Studio : 3.2.0.201311261642 Ti SDK : 3.2.0.v20131127110843 Mac OSX : 10.8.5 Alloy : 1.3.0 from github CLI - 3.2.0-beta Nexus 5 - android 4.4