[TIMOB-15840] CLI: iOS build fails if your tiapp.xml does not have any modules section.

GitHub Issue	n/a
Type	Bug
Priority	Critical
Status	Closed
Resolution	Fixed
Resolution Date	2013-12-03T18:47:10.000+0000
Affected Version/s	Release 3.2.0
Fix Version/s	2013 Sprint 25, 2013 Sprint 25 Core, Release 3.2.0, Release 3.3.0
Components	CLI, iOS
Labels	CLI, qe-testadded, regression, triage
Reporter	Sabil Rahim
Assignee	Chris Barber
Created	2013-11-28T00:06:21.000+0000
Updated	2014-02-19T09:33:52.000+0000

Description

If a app is created with no section in tiapp.xml the build fails

Reproduction Steps

1. Create a new sample app. 2. open the tiapp.xml and remove tag from it and save it. 3. build for simulator. The following error can be observed. [ERROR] : Failed to run command "build" [ERROR] : TypeError: Cannot call method 'filter' of undefined at iOSBuilder.checkIfNeedToRecompile (/Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.v20131127114913/iphone/cli/commands/_build.js:1594:45) at /Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.v20131127114913/node_modules/async/lib/async.js:548:21 at /Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.v20131127114913/node_modules/async/lib/async.js:224:13 at iterate (/Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.v20131127114913/node_modules/async/lib/async.js:131:13) at /Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.v20131127114913/node_modules/async/lib/async.js:142:25 at /Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.v20131127114913/node_modules/async/lib/async.js:226:17 at /Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.v20131127114913/node_modules/async/lib/async.js:553:34 at iOSBuilder.readBuildManifest (/Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.v20131127114913/iphone/cli/commands/_build.js:1395:2) at /Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.v20131127114913/node_modules/async/lib/async.js:548:21 at /Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.v20131127114913/node_modules/async/lib/async.js:224:13 --------------------------------------------- at run (/Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.v20131127114913/node_modules/node-appc/lib/subprocess.js:59:8) at /Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.v20131127114913/iphone/cli/lib/detect.js:356:9 at /Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.v20131127114913/node_modules/async/lib/async.js:508:21 at /Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.v20131127114913/node_modules/async/lib/async.js:224:13 at /Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.v20131127114913/node_modules/async/lib/async.js:108:13 at Array.forEach (native) at _each (/Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.v20131127114913/node_modules/async/lib/async.js:32:24) at async.each (/Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.v20131127114913/node_modules/async/lib/async.js:107:9)

Comments

Ingo Muschenetz 2013-11-28

Not clear if this a regression. That would help determine severity.
Chris Barber 2013-12-03

Master pull request: https://github.com/appcelerator/titanium_mobile/pull/5049 3.2.x pull request: https://github.com/appcelerator/titanium_mobile/pull/5050
Neha Mittal 2014-01-23

Verified fix with environment: Appcelerator Studio, build: 3.2.1.201401221450 SDK build: 3.2.1.v20140122175749 acs@1.0.11 alloy@1.3.1-beta3 npm@1.3.2 titanium@3.2.1-beta2 titanium-code-processor@1.1.0 Mac9(Maverick) Devices: Nexus 7(4.3) Now able to build project successfully if module section is removed from tiapp.xml.

JSON Source