Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-15943] iOS: TiErrorController layout incorrect when in landscape mode

GitHub Issuen/a
TypeBug
PriorityMedium
StatusClosed
ResolutionFixed
Resolution Date2014-03-15T17:31:51.000+0000
Affected Version/sn/a
Fix Version/s2014 Sprint 06, 2014 Sprint 06 SDK, Release 3.2.3, Release 3.3.0
ComponentsiOS
Labelsmodule_orientation, qe-testadded
ReporterDavid Bankier
AssigneePedro Enrique
Created2013-12-10T01:18:17.000+0000
Updated2014-03-19T07:07:18.000+0000

Description

TiErrorController uses 
[UIScreen mainScreen].applicationFrame
 to determine the error view's frame. That function always returns the portrait dimensions so that if an error is thrown and the application is in landscape the dismiss button and some of the message is off screen. The device needs to be physically turned to portrait orientation to dismiss the error. A PR is ready and a reference is on the way.

Comments

  1. David Bankier 2013-12-10

    PR: https://github.com/appcelerator/titanium_mobile/pull/5106
  2. Fokke Zandbergen 2013-12-10

    Why not make the screen less ugly while we're at it? * Dismiss button is terrible on iOS7 * Add a kitten
  3. Pedro Enrique 2014-03-04

    PR pending: https://github.com/appcelerator/titanium_mobile/pull/5418
  4. Pedro Enrique 2014-03-04

    Sample code 
       var win = Ti.UI.createWindow({
   	backgroundColor: '#ccc'
   });
   var btn = Ti.UI.createButton({
   	title:'Show Error',
   });
   
   btn.addEventListener('click', function(){
   	Ti.UI.createAwesomeApp();
   });
   
   win.add(btn)
    
   win.open();
    To test: 1. Run on app.js 2. Click the button. 3. Error screen will show 4. Rotate the screen (Error screen should rotate and still look good) 5. Close the red screen 6. Rotate 7. Click the button again 8. Error screen will show again and not look out of place.
  5. Vishal Duggal 2014-03-18

    Backport to 3_2_X https://github.com/appcelerator/titanium_mobile/pull/5489
  6. Pragya Rastogi 2014-03-19

    Verified the fix with: OSX: 10.9 Xcode: 5.1 Appcelerator Studio: 3.2.3.201403181115 SDK: 3.2.3.v20140318131613 acs:1.0.14 alloy:1.3.1 npm:1.3.2 titanium:3.2.1 titanium-code-processor:1.1.0 Device: iPhone 5s (7.1)

JSON Source