[TIMOB-16052] CLI: "Invalid Version: 3.2.0 copy"
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Medium |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2015-04-13T16:27:43.000+0000 |
| Affected Version/s | Release 3.2.0 |
| Fix Version/s | 2014 Sprint 09, 2014 Sprint 09 Tooling, Release 3.3.0 |
| Components | CLI |
| Labels | module_cli, qe-testadded |
| Reporter | Tony Lukasavage |
| Assignee | Chris Barber |
| Created | 2013-12-19T14:43:11.000+0000 |
| Updated | 2015-04-13T16:27:49.000+0000 |
Good find. For the record, the name of the directory containing the Titanium SDK *IS* the SDK's version number, not the number in the manifest.json. I hope to change that someday. In the meantime, the folder must be in the format "X.Y.Z" or "X.Y.Z.whatever" and possibly "X.Y.Z-whatever", but I don't recall.
I had the same problem, but with an older version of a module that I was using but in a different path -- it had underscores before the version number (__1.9.0) OLD VERSION (THAT I DIDN'T USE): /Library/Application Support/Titanium/modules/iphone/com.mymodule/__1.9.0 NEWEVER VERSION INCLUDED IN TIAPP.XML: /workspace/myApp/modules/com.mymodule/3.3.0 I just ended up removing the older version of the module, but it's still weird why that happened.
Titanium CLI master pull request: https://github.com/appcelerator/titanium/pull/130 Titanium SDK master pull request: https://github.com/appcelerator/titanium_mobile/pull/5630 To test: 1) Apply the changes to the CLI 2) Do a "master" branch build of the TiSDK (currently 3.3.0) 3) Install the 3.3.0 SDK (for Mac OS X, in ~/Library/Application Support/Titanium/osx) 4) Inside the SDK installation folder, rename the "3.3.0" folder to "foo" 5) Copy the "foo" folder to "bar" First test Titanium CLI commands: 6) ti sdk 7) ti sdk select 8) ti sdk select foo 9) ti sdk select bar 10) ti setup 11) ti setup quick 12) ti setup sdk 13) ti info 14) ti info -t titanium 15) ti info -t titanium -o json Now the SDK-level commands: 16) ti sdk select foo 17) ti create --name baz 18) cd baz 19) ti project 20) ti project sdk-version 21) ti build -p ios 22) build -p android 23) ti sdk select bar 24) ti build -p ios 25) ti build -p android
Fixed and ready for re-review.
This fails for me in two places: 1. Under "First test Titanium CLI commands:" step 10, within Titanium Setup, if I choose Check Environment, I get the following error:
Titanium SDK - latest sdk unknown (offline) /Users/tpoulsen/repos/titanium_appcelerator/node_modules/longjohn/dist/longjohn.js:185 throw e; ^ TypeError: Invalid Version: bar.0.0 at new SemVer (/Users/tpoulsen/repos/titanium_appcelerator/node_modules/node-appc/node_modules/semver/semver.js:271:11) at compare (/Users/tpoulsen/repos/titanium_appcelerator/node_modules/node-appc/node_modules/semver/semver.js:424:10) at Function.gte (/Users/tpoulsen/repos/titanium_appcelerator/node_modules/node-appc/node_modules/semver/semver.js:473:10) at Object.gte (/Users/tpoulsen/repos/titanium_appcelerator/node_modules/node-appc/lib/version.js:90:16) at /Users/tpoulsen/repos/titanium_appcelerator/lib/commands/setup.js:799:24 at /Users/tpoulsen/repos/titanium_appcelerator/lib/commands/setup.js:815:5 at /Users/tpoulsen/repos/titanium_appcelerator/node_modules/async/lib/async.js:533:17 at /Users/tpoulsen/repos/titanium_appcelerator/node_modules/async/lib/async.js:119:25 at /Users/tpoulsen/repos/titanium_appcelerator/node_modules/async/lib/async.js:24:16 at /Users/tpoulsen/repos/titanium_appcelerator/node_modules/async/lib/async.js:530:21 --------------------------------------------- at Request.init (/Users/tpoulsen/repos/titanium_appcelerator/node_modules/request/request.js:132:10) at new Request (/Users/tpoulsen/repos/titanium_appcelerator/node_modules/request/request.js:105:8) at request (/Users/tpoulsen/repos/titanium_appcelerator/node_modules/request/index.js:53:11) at /Users/tpoulsen/repos/titanium_appcelerator/lib/commands/setup.js:681:6 at /Users/tpoulsen/repos/titanium_appcelerator/node_modules/node-appc/lib/net.js:124:3 at asyncCallback (dns.js:68:16) at onanswer (dns.js:147:9)All steps work as described
Verified fixed on: Mac OSX 10.9.3 Appcelerator Studio, build: 3.3.0.201405121247 Titanium SDK, build: 3.3.0.v20140515133312 Titanium CLI, build: 3.3.0-dev Alloy: 1.4.0-alpha Used test steps provided by [~cbarber] and all worked as expected. Closing.