Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-16229] Don't check license for free modules on the marketplace

GitHub Issuen/a
TypeNew Feature
Priorityn/a
StatusOpen
ResolutionUnresolved
Affected Version/sn/a
Fix Version/sn/a
ComponentsTooling
Labelscb-tooling, license, marketplace, modules, verification
ReporterFokke Zandbergen
AssigneeUnknown
Created2014-01-17T19:23:43.000+0000
Updated2018-02-28T20:03:37.000+0000

Description

I've been getting lots of positive reactions to the launch of the [gitTio](http://gitt.io) search engine and CLI package manager. However, some people ran into problems after manually downloading and installing a distribution of a module available on GitHub, or using the [CLI](http://gitt.io/cli) to do this for them. This problem occurs when these modules are also listed on the [Appcelerator Marketplace](http://marketplace.appcelerator.com). When you download such a module straight from GitHub (or somewhere else), you will not be able to run an app using the module, because it will check with Marketplace if you have required the license.

Steps to reproduce

Create a new project: ti create -p ios -n license --id test.license -d .

Do *NOT* _purchase_ the free [ZIP / UnZIP module](https://marketplace.appcelerator.com/apps/1355) from the Marketplace

Download the distribution [straight from GitHub](https://github.com/mpociot/titanium-mobile-zip-module/blob/master/dist/de.marcelpociot.zip-iphone-1.1.zip) and add the dependency (<module platform="iphone" version="1.1">de.marcelpociot.zip</module>) to tiapp.xml or simply use the [gitTio CLI](http://gitt.io/cli): gittio install -g de.marcelpociot.zip in the project.

Build the project: ti build - ios

Meet the beautiful red screen attached.

Solution

Of course this license verification is great for paid modules, but for free modules this makes no sense. I can imagine people like the stats they get about the usage of their modules, but this could still be tracked, while not raising the red screen at the same time. I really urge you guys to consider this small modification. If the module is listed as *Free* on the marketplace, just track its usage, but *don't* trigger the red screen.

Attachments

FileDateSize
Schermafbeelding 2014-01-17 om 20.08.13.png2014-01-17T19:23:43.000+000063938

Comments

  1. Fokke Zandbergen 2014-01-17

    From Matt Apperson I hear that when listing their module people can choose for _Open Source_ and then have people redirect to the GitHub repo (which would have the distributions) and the verification would not happen? That would in theory solve the problem, but then still wouldn't it be easier to (also) just skip it for any free listing?
  2. Marcel Pociot 2014-01-17

    At the time I submitted my module (back in 2011) there was no "Open Source" category available in the marketplace. It's not possible to change the product type to "Open Source" once the module has been published.
  3. Ingo Muschenetz 2014-01-20

    I believe this is actually a feature request that needs to be handled on the server side. I will create a linked ticket.
  4. Timan Rebel 2014-02-18

    It is currently also impossible to use the 'Open Source' marked ti.Storekit module from the Marketplace. It redirects directly to Github and when I run the app with a development profile it throws the same Verification issue error. AdHoc works, but makes development much harder
  5. Ingo Muschenetz 2014-02-18

    We have done the necessary work on the server side to fix this, but need to get that tested and deployed.
  6. Timan Rebel 2014-02-18

    Thanks a lot! Any idea on the timeframe?
  7. Andrew Greenstreet 2014-08-04

    This is driving me crazy. I'm having to create new app UUID's all the time to get past licensing issues. Which of course makes it impossible to use: Analytics, and any kind of ACS functionality at all. My app will be working fine for a couple of days, but if make an adjustment of the app ID for testing purposes, boom, i get the unlicensed nonsense again. Would it be possible to say which module is unlicensed? 
       License violation detected. Unlicensed module(s) detected.  You must be a subscriber to use one or more of the modules included with this project.. Please contact Appcelerator Support.
    Which module is the problem here? I'm using all open source or modules I've created. I need to know which one is the problem, so I can go back, change the ID, and recompile it. Also, what does "Please contact Appcelerator Support." even mean? As far as I can tell, there isn't a single contact number, email address, or support form for the Marketplace, or related licensing issues.
  8. Chris Barber 2014-08-04

    [~andrew@gstreetmedia.com] The problem is that all modules free or paid are registered as paid modules in our backend database. This is a bug and we have escalated getting this fixed as soon as possible. This fix will only affect NEW free modules, not existing ones. We will need to figure out all of the free modules and fix the data in our database.
  9. Chris Barber 2014-08-04

    [~andrew@gstreetmedia.com] To expedite this, what free modules are you using? We can check those and get you up and running ASAP.
  10. Andrew Greenstreet 2014-08-04

    My manifest: 
        <module platform="iphone">com.gstreetmedia.aviarysdk</module><!-- mine -->
            <module platform="iphone">com.findingrover.utils</module><!-- mine -->
            <module platform="iphone">ti.styledlabel</module>
            <module platform="iphone">facebook</module>
            <module platform="iphone">ti.newrelic</module>
            <module platform="iphone">ti.mobileapptracker</module>
            <module platform="iphone">jp.msmc.gesturerecognizer</module>
            <module platform="iphone" version="1.0">de.marcelpociot.assetlibrary</module>
            <module platform="iphone">ti.map</module>
            <module platform="iphone">analytics.google</module>
    I've tried taking these out one by one, but can't really seem to pin down which one is the problem. Thanks much for the assistance.
  11. Fokke Zandbergen 2014-08-05

    This ticket has been open for months and months now and I hear lots of gitTio users complain about it. How hard can this be to fix anyway? 
        if (module.free) return true;
    ;)
  12. Andrew Greenstreet 2014-10-09

    Can you change the licensing message to reflect the module that is actually throwing the error? Sometimes the only way I can get my project to work, is remove all the modules, and add them back one by one, compiling and testing each time. Is this happening to users of my app? I have no idea, why this keeps popping up for me or how to fix it because I have no idea what module is the problem. Frankly, I'm not even sure a specific module is the issue, rather just the use of modules period.
  13. Chris Barber 2014-10-09

    [~andrew@gstreetmedia.com] I added this to the backend about 4 months ago and it just landed in production, unfortunately Titanium does not yet report these issues. I've created TIMOB-17834 and TIMOB-17835 to report modules that failed verification. In the meantime, you will need to comment out modules to figure out which ones are not passing verification.
  14. Fokke Zandbergen 2014-10-10

    [~cbarber], so this ticket is resolved now? That would be great!
  15. Chris Barber 2014-10-10

    [~fokke] Well, for brand new, never been downloaded by anyone, modules, yeah, it should be working. But for any existing free modules, we would need to manually flip a switch. :/
  16. Fokke Zandbergen 2014-10-10

    Curious about how you implemented it if it only works for new modules, but flipping the switch on existig should be as simple as a SQL REPLACE right?

JSON Source