[TIMOB-16427] CLI: Genymotion no longer ships with Google APIs, so hack check for 'google apps' in emu name should be reconsidered
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Low |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2016-09-02T07:15:05.000+0000 |
| Affected Version/s | Release 3.2.0 |
| Fix Version/s | Release 3.4.0 |
| Components | Android |
| Labels | n/a |
| Reporter | Stephen Feather |
| Assignee | Eric Merriman |
| Created | 2014-02-09T01:22:50.000+0000 |
| Updated | 2017-03-21T20:36:10.000+0000 |
Description
Since version 2, genymotion no longer ships with the Google APIs installed. Users must manually install the Google APIs themselves. The previous hack to check for the inclusion of Google APIs in a genymotion simulator that is not running no longer apply, and may, in the future, confuse those responsible for the maintenance of the cli.
genymotion.js, line 349
// this is a hack, but by default new Genymotion emulators that have Google APIs will
// say "Google Apps" in the name, so if we find that, assume it has Google APIs
if (emu && /google apps/i.test(emu.name)) {
emu.googleApis = true;
}
Moving this suggestion to engineering for further evaluation.
This was fixed in 3.4.0. We default to guessing if Google APIs are supported by checking the Genymotion emulator name. Then if the emulator is running, we connect to it and check the props to see if the Google APIs actually exist. In other words, we only know for sure if the emulator is running. Not much more we can do.
Closing ticket as fixed.