[TIMOB-16546] MobileWeb: ActivityIndicator does not animate properly on Firefox browser
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Low |
| Status | Closed |
| Resolution | Won't Fix |
| Resolution Date | 2017-06-29T18:44:02.000+0000 |
| Affected Version/s | Release 3.2.1 |
| Fix Version/s | n/a |
| Components | MobileWeb |
| Labels | n/a |
| Reporter | Andrew Greenstreet |
| Assignee | Chris Barber |
| Created | 2014-02-06T19:03:49.000+0000 |
| Updated | 2018-04-04T23:20:27.000+0000 |
Description
Animation does not work for activity indicator when using MobileWeb on Firefox. This is due to the setTimeout delay being too short.
This is fixed in this pull request:
https://github.com/appcelerator/titanium_mobile/pull/4968
Thank you for submitting this pull request. It appears that this pull request includes multiple improvements and fixes. Please submit one pull request for one issue. We would also need a test case that we can use to validate your issue and the fix. http://docs.appcelerator.com/titanium/latest/#!/guide/Pull_Request_Guide
I'd love to. However, Github seems to only let me submit on pull request at a time. And since my initial pull request is from November 14 (and was never acted upon) all subsequent commits to my fork are queuing up in the same pull request. I don't profess to be a Github expert, but each time I click "create pull request" is takes me back to my original.
I see now why you have unrelated changes in the same pull request. It is one of the gotchas of github. Please take a look at a nice article that describes the best practices. http://codeinthehole.com/writing/pull-requests-and-other-good-practices-for-teams-using-github/ An excerpt from the article: It's important to use a new branch for pull requests for several reasons: It allows you to submit multiple pull requests without confusion. The classical Github gotcha is to continue committing to a pull request branch after making the initial request. When these commits are pushed to the remote, they will become part of the original pull request which often ends up conflating unrelated functionality. Please resubmit individual pull requests for individual fixes / enhancements and we would take a look at them at a priority.
Please let us know if you plan to submit one pull request for one issue.
I'm keeping a list of things I'm fixing @ https://github.com/gstreetmedia/titanium_mobile_mobileweb Currently I'm having to fix at least one to two things daily. I'll try to push these back your way after I figure out Git (former Subversion user here).
Andrew - We have received multiple tickets and pull requests from you. Thank you for your dedication in making this platform better. I wanted to check with you if you plan to submit a pull request for this particular ticket or should we close it in favor of other pull requests. Let us know.
This item is fixed in https://github.com/appcelerator/titanium_mobile/pull/5371
Moving this ticket and PR to engineering for further evaluation.
Based on comments, sounds like it needs to be bumped until we have a better handle on how to fix it.
I've updated the code in my pull request @ https://github.com/appcelerator/titanium_mobile/pull/5371 This version uses png's, reduces a lot of code complexity at the expense of some size to house four flavors of the indicator (white small, black small, white big, black big). I've tested it on every browser I can get my hands on and it seems to work very well across the board. Submitted for your review.
[~andrew@gstreetmedia.com] Awesome! I'll take a peek as soon as I have a second to breathe. Appreciate the pull request. :)
Resolving ticket as "Won't fix" as MobileWeb has been deprecated.
Closing as will not fix.