Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-16925] Android: Build doesn't merge <resources> attributes in strings.xml files

GitHub Issuen/a
TypeStory
PriorityHigh
StatusClosed
ResolutionFixed
Resolution Date2014-05-07T21:16:13.000+0000
Affected Version/sn/a
Fix Version/s2014 Sprint 09, 2014 Sprint 09 Tooling, Release 3.3.0
ComponentsAndroid, Tooling
Labelsmodule_build, qe-closed-3.3.0, qe-testadded
ReporterChris Barber
AssigneeChris Barber
Created2014-05-06T22:15:36.000+0000
Updated2014-05-15T10:41:42.000+0000

Description

When merging Strings.xml (in the case of i18n strings), we need to merge the attributes of the root level tag and make sure there aren't any dupes.

Comments

  1. Chris Barber 2014-05-07

    Master pull request: https://github.com/appcelerator/titanium_mobile/pull/5668
  2. Priya Agarwal 2014-05-15

    Hello, Please provide the steps to test the issue.
  3. Chris Barber 2014-05-15

    To test: 1. create an android app 2. create a file /platform/android/res/values/strings.xml 3. place following content in file: 
       <?xml version="1.0" encoding="UTF-8"?>
   <resources foo="bar">
   	<string name="test" formatted="false">Test</string>
   </resources>
    4. build app 5. examine /build/android/res/values/strings.xml and notice that not only is the "test" string copied, but also the "foo" attribute
  4. Priya Agarwal 2014-05-15

    Verified the FIXED with: Appc-Studio:3.3.0.201405121247 sdk:3.3.0.v20140514163013 acs:1.0.14 alloy:1.4.0-alpha npm:1.3.2 titanium:3.3.0-dev titanium-code-processor:1.1.1 xcode:5.1.1 Device:Nexus7(v4.4.2) Followed above mentioned to test. Working as expected. Hence Closing the issue.

JSON Source