[TIMOB-17294] CLI: Android build has incorrect verbiage when installing apk

GitHub Issue	n/a
Type	Bug
Priority	High
Status	Closed
Resolution	Fixed
Resolution Date	2014-07-11T19:37:00.000+0000
Affected Version/s	Release 3.3.0
Fix Version/s	Release 3.3.0, Release 3.4.0
Components	Android, Tooling
Labels	n/a
Reporter	Chris Barber
Assignee	Chris Barber
Created	2014-07-11T18:36:10.000+0000
Updated	2014-07-11T21:58:14.000+0000

Description

When running an Android build, it displays:

[TRACE] Package manager is started

which has bad grammar. Should be:

[TRACE] Package manager has started

Then if ADB install fails, it will display:

[DEBUG] Package manager not started yet, trying again in 2000ms...

This is confusing since ADB install will not start until the system_server process is running which assumes the package manager has started. It needs to display:

[DEBUG] ADB install failed because package manager service is still starting, trying again in 2000ms...

Comments

Chris Barber 2014-07-11

Master: https://github.com/appcelerator/titanium_mobile/pull/5905 3_3_X: https://github.com/appcelerator/titanium_mobile/pull/5906 To test, build an Android app (probably for emulator) and watch the output. You may need a REALLY slow machine and an ARM emulator to see the second message.
Tim Poulsen 2014-07-11

I can confirm that the first message (Package manager has started) is correctly displayed. Despite repeated attempts, the build/install always worked so I never saw message number two. It's in the code, so I'm sure it's going to work as described.
Lokesh Choudhary 2014-07-11

Verified the fix. The correct verbiage is seen in studio logs: [TRACE] : Package manager has started & [DEBUG] : ADB install failed because package manager service is still starting, trying again in 2000ms... Closing. Environment: Appc Studio : 3.3.0.201407101409 Ti SDK : 3.3.0.v20140711123603 Mac OSX : 10.8.5 Alloy : 1.4.0-rc5 CLI - 3.3.0-rc4 Code Processor: 1.1.1 Nexus 5 - android 4.4

JSON Source