[TIMOB-17348] Remove non-production npm dependencies from Titanium SDK
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | Medium |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2014-07-21T21:03:17.000+0000 |
| Affected Version/s | Release 3.3.0 |
| Fix Version/s | Release 3.3.1, Release 3.4.0 |
| Components | Tooling |
| Labels | module_build, qe-manualtest |
| Reporter | Chris Barber |
| Assignee | Chris Barber |
| Created | 2014-07-18T23:34:38.000+0000 |
| Updated | 2014-08-15T18:16:49.000+0000 |
Description
The full npm dependencies have been committed to the Titanium Mobile repo and should be stripped back to the production-only files.
Master: https://github.com/appcelerator/titanium_mobile/pull/5921 3_3_X: https://github.com/appcelerator/titanium_mobile/pull/5922
Ended up ripping out 735 files. Whoot!
I can do the following with this PR. Is that a suitable test to pass the review? * Build the SDK from source * Install the resulting SDK * Create an app (from the CLI) * Build that app for iOS and Android and successfully install & run the app on the simulator/emulator (from the CLI)
[~skypanther] Yeah, just scons, create an app, and build it. If there were any issues, you'd see it doing those steps.
Approved and merged
Tested on: Mac OSX 10.9.4 Windows 8.1 (x64) Ubuntu 14.04 LTS (x64) Appcelerator Studio, build: 3.3.0.201407111535 Titanium SDK, build: 3.3.1.v20140814203318, 3.4.0.v20140813022514 Titanium CLI, build: 3.3.0 Alloy: 1.4.1 Android Device: Nexus 4 (4.2) Android Emulator: 4.4.2 BlackBerry Device: Z10 (10.2.1.2947) BlackBerry Simulator: 10.3.0.698 iOS Device: iPhone 5 (7.0.6) iOS Simulator: 7.1 Tested creation of Classic and Alloy applications against Android, BlackBerry, iOS, and Mobileweb on Mac, Windows and Ubuntu. All apps created and built successfully to Emulator and Device. Closing.