[TIMOB-17946] Android Module: Fails to Build with 3.4.0.GA TiSDK

GitHub Issue	n/a
Type	Bug
Priority	High
Status	Closed
Resolution	Fixed
Resolution Date	2014-11-04T19:23:14.000+0000
Affected Version/s	Release 3.4.0
Fix Version/s	Release 3.4.1, Release 3.4.2, Release 3.5.0, Release 4.0.0
Components	Android
Labels	n/a
Reporter	Eduardo Gomez
Assignee	Hieu Pham
Created	2014-10-31T23:31:17.000+0000
Updated	2014-11-21T18:35:40.000+0000

Description

Issue description

Calling Native Extensions (which are effectively native Ti Modules) that are build and then added to a Titanium app as modules. It fails to build on 3.4.0.GA although works on 3.3.0.GA (logs per each SDK attached). The example is a Hello World Module.

Steps to replicate

Unzip the attached module

set its build properties as I outlined above so that it uses the following:

3.3.0.GA, Android/Google 14 SDK, r8d NDK.

Run the command, "ant dist"

Notice that the build is Successful (Logs attached)

Change the TiSDK to 3.4.0.GA

Run the command, "ant dist"

Notice that the build fails (Logs attached)

Change the TiSDK back to 3.3.0.GA

Changing the NDK to r9 as recommended does not address the issue either. http://docs.appcelerator.com/titanium/latest/#!/guide/Installing_the_Android_NDK We cannot seem to build this module with the 3.4.0.GA TiSDK, I've tried all sorts of combos, any ideas why we cannot build the module with for example the r8d, or r9 NDK, the 3.4.0.GA TiSDK and the Android-18 and Google-18 APIs. Thats seems like the combo we want but its not working.

Combos Tried:

3.5.0 CI

{quote} |TISDK|NDK|Android SDK & Google APIs|SUCCESS| |3.5.0.v20141028174916| r8d| 14 | No |3.5.0.v20141028174916| r9| 14 | No |3.5.0.v20141028174916| r8d| 18 | No |3.5.0.v20141028174916| r9| 18 | No {quote}

3.4.2

{quote} |TISDK|NDK|Android SDK & Google APIs|SUCCESS| |3.4.2.v20141028145714| r8d| 14 | No |3.4.2.v20141028145714| r9| 14 | No |3.4.2.v20141028145714| r8d| 18 | No |3.4.2.v20141028145714| r9| 18 | No {quote}

3.4.0.GA

{quote} |TISDK|NDK|Android SDK & Google APIs|SUCCESS| |3.4.0.GA| r8d| 14 | No |3.4.0.GA| r9| 14 | No |3.4.0.GA| r8d| 18 | No |3.4.0.GA| r9| 18 | No {quote}

3.3.0.GA

{quote} |TISDK|NDK|Android SDK & Google APIs|SUCCESS| |3.3.0.GA| r8d| 14 | YES |3.3.0.GA| r9| 14 | YES |3.3.0.GA| r8d| 18 | YES |3.3.0.GA| r9| 18 | YES {quote} These are the following build.properties:

titanium.platform=/Users/egomez/Library/Application Support/Titanium/mobilesdk/osx/3.3.0.GA/android
android.platform=/Users/egomez/android-sdks/platforms/android-14
google.apis=/Users/egomez/android-sdks/add-ons/addon-google_apis-google-14
android.sdk=/Users/egomez/android-sdks
android.ndk=/Users/egomez/android-ndk-r8

NDKs

r8d NDK: http://dl.google.com/android/ndk/android-ndk-r8d-darwin-x86.tar.bz2 r9 NDK: http://dl.google.com/android/ndk/android-ndk-r9-darwin-x86.tar.bz2

Attachments

File	Date	Size
HelloWorld_Android.zip	2014-10-31T23:31:17.000+0000	2439661
Logs_3.3.0.GA.txt	2014-10-31T23:31:17.000+0000	17794
Logs_3.4.0.GA.txt	2014-10-31T23:31:17.000+0000	17582

Comments

Ingo Muschenetz 2014-10-31

Issue is here:

   [javac] /Users/egomez/modules/HelloWorld_Android/build/generated/java/com/mfoundry/mb/helloworld/AssetCryptImpl.java:13: com.mfoundry.mb.helloworld.AssetCryptImpl is not abstract and does not override abstract method setIsProduction(boolean) in org.appcelerator.kroll.util.KrollAssetHelper.AssetCrypt

We should have a default implementation.

Eduardo Gomez 2014-10-31

is there a way to possibly override this method? It seems to be overwritten every time we build. e.g. http://stackoverflow.com/questions/18813580/actionlistener-is-abstract-and-does-not-override-abstract-method-actionperformed
Hieu Pham 2014-11-03

master PR: https://github.com/appcelerator/titanium_mobile/pull/6299 3.4.1 PR: https://github.com/appcelerator/titanium_mobile/pull/6303

Lokesh Choudhary 2014-11-04

Followed the steps above in the description to verify the fix. Android module builds successfully with latest 3.4.1 & 3.5.0 SDK.

build.properties:

   titanium.platform=/Users/lokeshchoudhary/Library/Application\ Support/Titanium/mobilesdk/osx/3.4.1.v20141103164118/android
   android.platform=/Users/lokeshchoudhary/Desktop/android-sdk-macosx/platforms/android-19
   google.apis=/Users/lokeshchoudhary/Desktop/android-sdk-macosx/add-ons/addon-google_apis-google-19
   android.sdk=/Users/lokeshchoudhary/Desktop/android-sdk-macosx
   android.ndk=/Users/lokeshchoudhary/Desktop/androidNDK/android-ndk-r10c

Success logs:

   dist:
         [jar] Building jar: /Users/lokeshchoudhary/Desktop/HelloWorld_Android/dist/helloworld_android.jar
   
   post.jar:
   
   python.set.exec:
   
   python.check:
        [echo] Testing for Python
        [exec] Python 2.7.6
   
   init:
   
   pre.docgen:
   
   docgen:
        [exec] Generating /Users/lokeshchoudhary/Desktop/HelloWorld_Android/build/docs/index.html
   
   post.docgen:
   
   check.respackage:
         [zip] Building zip: /Users/lokeshchoudhary/Desktop/HelloWorld_Android/dist/com.mfoundry.mb.helloworld-android-2.0.0.zip
   
   libs.check:
   
   zip.libs:
         [zip] Updating zip: /Users/lokeshchoudhary/Desktop/HelloWorld_Android/dist/com.mfoundry.mb.helloworld-android-2.0.0.zip
   
   zip.metadata:
         [zip] Updating zip: /Users/lokeshchoudhary/Desktop/HelloWorld_Android/dist/com.mfoundry.mb.helloworld-android-2.0.0.zip
   
   clean.respackage:
   
   post.dist:
   
   BUILD SUCCESSFUL
   Total time: 11 seconds

Environment: Appc Studio : 3.4.1.201410281743 Ti SDK : 3.4.1.v20141103164118 , 3.5.0.v20141104101714 CLI : 3.4.1-dev Alloy : 1.5.1 GA Code Processor : 1.1.1 Android NDK : android-ndk-r10c , android-ndk64bit-r10 , android-ndk32bit-r10 MAC Yosemite : 10.10

Ingo Muschenetz 2014-11-04

This should not be closed yet. There is an outstanding PR.
Hieu Pham 2014-11-04

3.4.X PR: https://github.com/appcelerator/titanium_mobile/pull/6307
Lokesh Choudhary 2014-11-11

Verified the fix with 3.4.2.v20141110181757. The android module builds successfully. Closing. Environment: Appc Studio : 3.4.1.201410281743 Ti SDK : 3.4.2.v20141110181757 CLI : 3.4.1-alpha Alloy : 1.5.1 GA Code Processor : 1.1.1 MAC Yosemite : 10.10 Android NDK : android-ndk-r10c

JSON Source