[TIMOB-18138] CLI: ti setup, network option, setting proxy to no doesn't clear value from config file
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Medium |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2016-08-18T15:54:32.000+0000 |
| Affected Version/s | Release 3.4.1 |
| Fix Version/s | titanium 5.0.9 |
| Components | CLI |
| Labels | n/a |
| Reporter | Tim Poulsen |
| Assignee | Feon Sua Xin Miao |
| Created | 2014-12-04T18:32:00.000+0000 |
| Updated | 2017-03-21T18:39:17.000+0000 |
Description
Steps to reproduce:
1. Run
ti setup
2. Choose network
3. When prompted if you're behind a proxy, enter "yes" then enter a proxy address (e.g. http://localhost). Complete the rest of the questions, accepting the defaults.
4. Choose network
5. When prompted, enter "no" to specify that you're not behind a proxy. Complete the rest of the questions.
6. Choose network. The prompts show that "yes" you're behind a proxy. If you examine the ~/.titanium/config.json file you'll see that the proxy address is still listed in the httpProxyServer key.
Expectation - if you specify no, the proxy value would be cleared and further prompts by setup would default to no.
PR: https://github.com/appcelerator/titanium/pull/190 Follow steps to reproduce stated above, the proxy value should be cleared if option No is selected.
FR/CR pass, merged
Followed the above test steps for checking the fix & the proxy value still exists in the config file. Reopening. Environment: Appc Studio : 4.1.0.201505071004 Ti SDK : 4.1.0.v20150605164428 CLI : 4.0.1 Alloy : 1.6.0 MAC Yosemite : 10.10.3 Appc npm : 4.0.0 Appc CLI : 4.0.2-rc2 Node: v0.10.37
I re-verified with Titanium CLI 5.0.9 and it works as expected. Resolving fixed.
Closing ticket as fixed.