[TIMOB-18847] Move Ti.Android.ActionBar to Ti.UI.Android.ActionBar

GitHub Issue	n/a
Type	Improvement
Priority	Low
Status	Closed
Resolution	Fixed
Resolution Date	2015-06-16T23:21:03.000+0000
Affected Version/s	n/a
Fix Version/s	Release 4.1.0
Components	Android
Labels	actionbar
Reporter	Christopher Williams
Assignee	Ashraf Abu
Created	2015-04-23T19:19:12.000+0000
Updated	2017-03-16T21:53:36.000+0000

Description

The ActionBar class/proxy is a UI one and should live with the other Android specific types in Ti.UI.Android namespace.

Comments

Ashraf Abu 2015-06-05

The ActionBar is inside Ti.Android as it is needed by the ActivityProxy and TiBaseActivity. It can be seen as a core component needed in there. Not sure if this is advisable. I think it makes sense for it to stay in Ti.Android and not move it to the UI package. Also, based on the docs: http://docs.appcelerator.com/platform/latest/#!/api/Titanium.Android.ActionBar You normally get access to the ActionBar via the Activity (Window). [~hpham] What do you think?

Ashraf Abu 2015-06-11

[~cwilliams] ActionBar in Android is only accessed through something like this:-

   win.activity.actionBar

or in alloy

   <Alloy>
       <Window title="My Test App">
           <ActionBar id="actionbar" title="My XML Menu" onHomeIconItemSelected="doMenuClick" />
           <Menu>
               <MenuItem id="item1" title="Settings" onClick="openSettings" />
               <MenuItem id="item2" title="Search" onClick="doSearch" />
           </Menu>
           <Label id="label">Welcome!</Label>
       </Window>
   </Alloy>

Basically, the name space doesn't really matter in this case. If there's a change needed, it's only probably just document change needed. Can this be resolved as Invalid? Or should the documents be changed?

Ashraf Abu 2015-06-15

If there's nothing else, I'll close this ticket tomorrow.
Lee Morris 2017-03-16

Closing ticket as the issue has been fixed.

JSON Source