[TIMOB-18906] Facebook: Problems in 'presentWebShareDialog'
| GitHub Issue | n/a |
|---|
| Type | Bug |
|---|
| Priority | Critical |
|---|
| Status | Closed |
|---|
| Resolution | Done |
|---|
| Resolution Date | 2015-07-01T05:31:24.000+0000 |
|---|
| Affected Version/s | n/a |
|---|
| Fix Version/s | n/a |
|---|
| Components | Android |
|---|
| Labels | android, facebook, sdk-4.0.0RC3 |
|---|
| Reporter | Giulio De Giorgio |
|---|
| Assignee | Ashraf Abu |
|---|
| Created | 2015-05-12T07:40:05.000+0000 |
|---|
| Updated | 2017-03-16T22:54:21.000+0000 |
|---|
Description
The first problem is that documentation say that is not necessary to do login flow before the use of presentWebShareDialog, but if i don't do that the app crash with the stack error: 'session cannot be null' in android log cat.
The second problem occurs when i try to use presentWebShareDialog after login: the facebook share popup seems to not get the passed params: link, name, caption, picture and description
!Screenshot_fb.png|thumbnail!
Attachments
[~norx85] can you please attach a test case?
I attached two simple example apps of the two cases
To reproduce the problem you need to not have facebook app installed on the device
Any news on this bug? The issue remains in sdk 4.0.0GA but now it's also impossible to share after login flow. I need a fix on this or i can't publish my app. Thanks
Have you tried the 4.0.4+ version of the Facebook module? And have you changed the way the facebook app is set up in tiapp.xml ? Also provided the right info on the Facebook Developer app settings page? I had to update to this version to get everything working after the Facebook API changes. https://github.com/appcelerator-modules/ti.facebook (I had to build it locally myself for it to work, for some reason though) It's also a good point you made, that the documentation should explain a bit better how the different login flows work when/if you have the FB app installed (on iOS or Android). (or also connected in the main phone settings.)
[~norx85] Hi there. -I tried your code and everything seems to be working.- I used the 4.0.5 version of the Facebook module. You can get it here: https://github.com/appcelerator-modules/ti.facebook/releases -Let me know if this works for you.- New note:- I managed to get the bug for the first case. The second case seems to be okay.
[~kosso] You had to locally build the module? Is the module not working correctly from the release page?
Ok i'll give a try to this version
For the first problem, login flow is required and in this case, the documentation is wrong. I've done this PR https://github.com/appcelerator-modules/ti.facebook/pull/24 to reflect that. For the second issue, the 4.0.5 version of the Facebook module handles that and solves that problem. You can get it here: https://github.com/appcelerator-modules/ti.facebook/releases If nothing else is required, I think I can resolve this ticket with respect to the original problems of this ticket.
Resolving this as done.
Closing ticket as done.